Fix user settings deleted on update#48
Merged
Merged
Conversation
Radial Actions currently stores settings beside the executable. The MSI authoring removed every file in the install folder during upgrade and uninstall with a wildcard RemoveFile entry, which could match user-owned files such as RadialActions.settings or recovery snapshots. This removes only that wildcard cleanup. The existing RemoveFolder entry remains, so Windows Installer can still remove the install directory when it is empty, but it will no longer delete files it does not own just to make the directory removable. This PR intentionally avoids adding graceful close behavior or WiX Util authoring. It is the smallest installer data-safety change and can be reviewed independently from the settings persistence work.
danielchalmers
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #46.
This is the smallest installer data-safety change from the issue: remove the wildcard
RemoveFile Name="*.*"cleanup from the main executable component.Settings currently live beside the executable, so wildcard-deleting the install folder can remove user-owned files such as:
RadialActions.settings.corrupt-*recovery snapshots from the settings safety PRThe existing
RemoveFolderentry remains. Windows Installer can still remove the install folder when it is empty, but the MSI no longer deletes files it does not own just to make cleanup look complete.Out Of Scope
CloseApplicationValidation
dotnet test RadialActions.sln(62 passed)dotnet publish .\RadialActions\RadialActions.csproj -o publish\x64 -c Release -f net10.0-windows --os win --arch x64 --self-contained -p:PublishSingleFile=true -p:DebugType=embedded -p:Version=1.2.3wix build Package.wxs -arch x64 -d Version=1.2.3 -d Arch=x64 -o publish\RadialActions-1.2.3-x64.msi