Fix F5 debug profile and blocked-page state#105
Closed
danielchalmers wants to merge 2 commits into
Closed
Conversation
Owner
Author
|
This is a complex and messy solution that is not actually passing tests either. Need more planning in #104. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root Cause
F5 was loading the latest built extension, but the persistent Chrome debug profile restored stale blocked-page tabs and kept Chrome's crashed-session marker. Those restored pages still had the old
?url=blocked-page URL, which made the debug session look like it was running old code and showedBlock details unavailable. Separately, extension-page runtime messages needed to resolve state byblockIdbecausesender.tabis not reliable from the blocked page.Validation
npm run typechecknpm run typecheck:testnpm run build:devnpm run lintnpm exec prettier -- --check .vscode/launch.json .vscode/tasks.jsonnpm exec playwright -- test test/e2e/blocked.spec.tsabout:blanktab with no restore prompt; navigating tohttps://www.google.com/search?q=asdfblocked with?blockId=...and rendered the responsible filter details.Closes #104