Add .gitattributes to normalize line endings to LF#108
Merged
Conversation
Force text files to check out with LF in every working tree regardless of core.autocrlf, so Prettier's default endOfLine: "lf" stays green on Windows. Resolves local `prettier --check` failures caused by CRLF checkouts; CI (Linux) already used LF.
danielchalmers
force-pushed
the
chore/gitattributes-eol
branch
from
faac35d to
695c09a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
.gitattributesthat forces text files to check out with LF in every working tree, overridingcore.autocrlf. PNG/ZIP assets stay binary.Why
The repo has no
.gitattributesand Windows clones typically runcore.autocrlf=true, so the working tree gets CRLF while Prettier defaults toendOfLine: "lf". That makesnpm run format:checkfail locally on every text file (41 of them) even though the committed blobs are LF and CI (Linux) passes. This pins LF everywhere so local and CI behavior match.Verification
After re-applying attributes to the working tree:
src/shared/constants.tsline endings: CRLF → LFprettier . --check→ "All matched files use Prettier code style!" (previously failed on 41 files)Independent of #107 — branched off
main.