fix(generateString): Implement handling of single param in generateSt…#14
Open
kyle-cameron-zz wants to merge 2 commits intodanielnovograd:masterfrom
Open
fix(generateString): Implement handling of single param in generateSt…#14kyle-cameron-zz wants to merge 2 commits intodanielnovograd:masterfrom
kyle-cameron-zz wants to merge 2 commits intodanielnovograd:masterfrom
Conversation
…ring function When a single parameter is passed into generateString, a string of that length is returned. danielnovograd#13
Codecov Report
@@ Coverage Diff @@
## master #14 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 1 1
Lines 111 116 +5
=====================================
+ Hits 111 116 +5
Continue to review full report at Codecov.
|
danielnovograd
requested changes
Jun 15, 2017
Owner
There was a problem hiding this comment.
Please see the related issue. Also, the latest commit does not fix the package.json issue.
See code. Very small changes. danielnovograd#14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ring function
When a single parameter is passed into generateString, a string of that length is returned.
#13