Respect windowFeatures with falsy windowName#16
Open
gpittarelli wants to merge 1 commit into
Open
Conversation
Currently, if you do `blankshield.open('url', '', 'width=100')` the `'width=100'` (and any other windowFeatures) is effectively ignored because they actually get passed to `window.open` as the second argument (windowName). This change always fills in a windowName argument, so that windowFeatures will always be correctly passed as the third argument.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, if you do
blankshield.open('url', '', 'width=100')the'width=100'(and any other windowFeatures) is effectively ignored because they actually get passed towindow.openas the second argument (windowName). This change always fills in a windowName argument, so that windowFeatures will always be correctly passed as the third argument.