Round 0: install-skills builds binary; agents pinned to worktree#83
Merged
mattleaverton merged 9 commits intoApr 24, 2026
Conversation
…racts From first real PR review workflow run: - Phase 0.9: config/auto-detect conflict, require_clean default, missing env vars in tool nodes, CLI headless warning, error message hints, worktree file-not-found context - Phase 3.7-3.9: run input contract (--input), output contract, node data passing conventions - Future work: iteration patterns (dynamic loops over collections) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Setup/build/test tool nodes + single review agent node. Experimental workflow for automated PR triage. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Setup script now copies build-test.sh to .ai/ before gh pr checkout changes the branch and removes workflow files. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Raw git checkout (no gh pr checkout) with unique branch names for parallel safety - Separate investigate (exploratory, full tool access) and decide (directive, no tools) agents - Tighter output contract: next actions instead of follow-up tasks - Setup script preserves all workflow scripts to .ai/ before branch switch Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Absolute path for setup script (works from any repo's worktree) - Remove Go-specific assumptions from investigate prompt - Agent discovers build system and runs appropriate checks - Add freshell run config Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
# Conflicts: # workflows/pr-review/scripts/build-test.sh # workflows/pr-review/scripts/setup-pr.sh
From docs/plans/2026-04-24-kilroy-fixes-from-feedback.md items danshapiro#5 and danshapiro#1 (engine half) — the two defaults bugs that must land before we can safely dogfood the remaining fixes through quick-launch. danshapiro#5 install-skills.sh builds before linking. A stale binary on PATH was silently breaking skills that depend on newer flags (--tmux, --prompt-file, --label, --package). One `go build` at install time is cheap insurance. danshapiro#1 Agent system prompts now include a worktree-context preamble: "You are running inside an isolated Kilroy worktree at <path>. Do not cd elsewhere or pass -C to git with paths outside cwd." Applied in both the tmux agent handler (primary) and the CodergenHandler API/subprocess path. Without this, a prompt that casually mentions a user's source-tree path would pull agents out of their worktree and clobber the real checkout. Also folds in the pre-existing cleanup that moved quick-launch and pr-review skills + workflow packages to gf-software-factory, and adds the feedback plan doc that drives the rest of this initiative. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
3 tasks
mattleaverton
deleted the
fix/round-0-worktree-prepend-and-install-build
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Round 0 of the feedback-plan rollout (
docs/plans/2026-04-24-kilroy-fixes-from-feedback.md) — the two defaults bugs that must land before we can safely dogfood the remaining fixes throughquick-launch.install-skills.shbuilds before linking. Stale binaries on PATH were silently breaking skills that depend on newer flags (--tmux,--prompt-file,--label,--package). A singlego buildat install time eliminates the failure mode.<path>. Do not cd elsewhere or pass -C to git with paths outside cwd." Applied in both the tmux agent handler (primary) and theCodergenHandlerAPI/subprocess path. Without this, a prompt that casually mentions a user's main-source path would pull agents out of their worktree and clobber the real checkout.Also folds in the pre-existing cleanup that moved
quick-launchandpr-reviewskills + workflow packages togf-software-factory, and adds the feedback plan doc that drives the rest of this initiative.Test plan
go test ./internal/attractor/engine/— passes, incl. newTestBuildWorktreeContextPreamble_*go test ./internal/attractor/agents/— passes, incl. updatedTestTmuxAgentHandler_FakeAgent_SuccessfulExecutionasserting preamble is inprompt.mdbash scripts/install-skills.sh— builds + links correctly end-to-endkilroy attractor run --tmuxthatprompt.mdincludes the preamble (happens implicitly during Round 1 dogfooding)Round 1 — what unlocks after this merges
With a reliable install + worktree-pinned agents, we fan out one
quick-launchrun per remaining engine defaults bug:run_completed/run_failedinprogress.ndjsonKILROY_PREDECESSOR_NODEenv for failure handlers🤖 Generated with Claude Code