Skip to content

Batch dependabot updates and fix single-line clip edit spacing#108

Merged
dantheuber merged 3 commits into
mainfrom
dependabot-updates
Apr 4, 2026
Merged

Batch dependabot updates and fix single-line clip edit spacing#108
dantheuber merged 3 commits into
mainfrom
dependabot-updates

Conversation

@dantheuber
Copy link
Copy Markdown
Owner

@dantheuber dantheuber commented Apr 4, 2026

Summary

  • Consolidates 10 open Dependabot PRs into a single branch with verified, safe version bumps
  • Fixes a layout bug where single-line text clips grew slightly taller when entering edit mode, creating a visible gap between rows

Dependency Updates

Direct (package.json)

Package From To Type
electron ^35.1.5 ^35.7.5 Patch (bug fixes incl. Windows ffmpeg, shell.openPath)
electron-builder ^25.1.8 ^26.8.1 Major (no breaking config changes, removes @tootallnate/once)
vite ^6.2.6 ^6.4.1 Minor/patch (security hardening, bug fixes)
react-syntax-highlighter ^15.6.1 ^16.1.0 Major (refractor v5; all deep ESM import paths verified intact)

Transitive (resolved via lockfile)

Addresses security advisories in: rollup, minimatch (ReDoS), lodash (prototype pollution), js-yaml (prototype pollution), tmp, form-data

Supersedes: #105, #104, #103, #97, #96, #95, #92, #90, #89, #88

Bug Fix: Single-Line Edit Spacing

When clicking a single-line text clip to edit, the row height increased slightly due to the expanded CSS class being applied unconditionally. This caused a visible gap between the edited clip and the one below it.

Root cause: expanded set max-height: none and align-items: flex-start on the clip row regardless of content line count, and the auto-resize effect set explicit heights on the textarea/container even for single-line content.

Fix:

  • Only apply expanded class for multiline content (ClipWrapper.tsx)
  • Split auto-resize into single-line (reset to natural height) and multiline (dynamic resize) paths (TextClip.tsx)
  • Scope align-self: flex-start on .textEditorWrapper to only apply under .clipRow.expanded (Clip.module.css)

Test plan

  • Lint — zero errors, zero warnings
  • TypeScript — zero errors across both tsconfig.node.json and tsconfig.web.json
  • Unit tests — 342 passed, 100% coverage (statements, branches, functions, lines)
  • E2E tests — 18/18 passed
  • Manually verify single-line clip edit no longer causes row height shift
  • Manually verify multiline clip edit still expands correctly
  • Verify syntax highlighting renders correctly with react-syntax-highlighter v16
  • Test production build (npm run build:win)

electron: ^35.1.5 → ^35.7.5 (patch fixes)
electron-builder: ^25.1.8 → ^26.8.1 (major, no breaking config changes)
vite: ^6.2.6 → ^6.4.1 (minor/patch)
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 4, 2026

📊 Coverage Report

Metric Coverage
Statements 100%
Branches 100%
Functions 100%
Lines 100%

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 4, 2026

🧪 E2E Test Results

18 passed, 0 failed, 0 skipped

Test Suite Result
App Launch
Clipboard
Context Menu
Image Clipboard
Quick Clips
Settings
Theme
Settings — Search Terms CRUD
Settings — Quick Tools CRUD
Settings — Templates CRUD
Tools Launcher — Pattern Scanning
Tools Launcher — Clip Templates

@dantheuber dantheuber merged commit edfbffe into main Apr 4, 2026
3 checks passed
@dantheuber dantheuber deleted the dependabot-updates branch April 4, 2026 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant