Batch dependabot updates and fix single-line clip edit spacing#108
Merged
Conversation
electron: ^35.1.5 → ^35.7.5 (patch fixes) electron-builder: ^25.1.8 → ^26.8.1 (major, no breaking config changes) vite: ^6.2.6 → ^6.4.1 (minor/patch)
📊 Coverage Report
|
🧪 E2E Test Results✅ 18 passed, 0 failed, 0 skipped
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dependency Updates
Direct (package.json)
electronshell.openPath)electron-builder@tootallnate/once)vitereact-syntax-highlighterTransitive (resolved via lockfile)
Addresses security advisories in:
rollup,minimatch(ReDoS),lodash(prototype pollution),js-yaml(prototype pollution),tmp,form-dataSupersedes: #105, #104, #103, #97, #96, #95, #92, #90, #89, #88
Bug Fix: Single-Line Edit Spacing
When clicking a single-line text clip to edit, the row height increased slightly due to the
expandedCSS class being applied unconditionally. This caused a visible gap between the edited clip and the one below it.Root cause:
expandedsetmax-height: noneandalign-items: flex-starton the clip row regardless of content line count, and the auto-resize effect set explicit heights on the textarea/container even for single-line content.Fix:
expandedclass for multiline content (ClipWrapper.tsx)TextClip.tsx)align-self: flex-starton.textEditorWrapperto only apply under.clipRow.expanded(Clip.module.css)Test plan
tsconfig.node.jsonandtsconfig.web.jsonnpm run build:win)