Open
Conversation
Also removed Yahoo Provider, since the service is no longer available. For details see: https://stackoverflow.com/questions/47099005/did-yahoo-finance-just-discontinue-their-csv-download
Author
|
PS: I've also commented the Bitcoin integration, since there does not seem to be support for it in the Money framework anymore - at least I did not found the corresponding currency in the Xcode 9 branch ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull requests add support for Swift v4 in
FX. Please note, my main goal was to get this working again - not to provide a fully overhauled API. That said, folks can at least useFXagain in their projects and we got a new common ground to build upon.This pull requests depends on danthorpe/Money#92 - which adds arithmetic support for
ISOMoneywhen used together withDecimal.I've added a new protocol
ISOMoneyProtocolwhich to allows aFXProviderto work with all available currencies (ISOMoneyProtocolbridges the needed values fromISOMoney<C: ISOCurrencyProtocol>in a generic way). You may or may not want to moveISOMoneyProtocolto theMoneyframework instead ofFX.The dependency upon
ValueCodingis completely removed as it's obsolete. However, I did not implement theCodeableprotocol. Shouldn't be too hard to add it if anyone needs it.The Yahoo Provider is completely removed too, since the service is no longer available. For details see: https://stackoverflow.com/questions/47099005/did-yahoo-finance-just-discontinue-their-csv-download