Update Readme, Include support for new function Get-AllVMSnapshot#9
Open
nshores wants to merge 2 commits into
Open
Update Readme, Include support for new function Get-AllVMSnapshot#9nshores wants to merge 2 commits into
nshores wants to merge 2 commits into
Conversation
dapacruz
requested changes
Sep 12, 2020
dapacruz
left a comment
dapacruz
left a comment
Owner
There was a problem hiding this comment.
Please fix these minor issues.
| **Get-VMCpuReadyPercent** | ||
| Calculates the CPU ready percent average of virtual machines provided | ||
|
|
||
| **Get-VMCpuReadyPercent** |
Owner
There was a problem hiding this comment.
Duplicated from line 43 and 44.
| **Get-VMCpuReadyPercent** | ||
| Calculates the CPU ready percent average of virtual machines provided | ||
|
|
||
| **Get-AllVMsnapshot** |
Owner
There was a problem hiding this comment.
Please rename the function to Get-SnapshotAll. This helps with sorting, the included command is Get-Snapshot.
Owner
There was a problem hiding this comment.
Thinking Get-SnapshotHidden might be better.
| $snapshotfinal = @() | ||
| $vmlist = get-vm $VM | ||
|
|
||
| #Get a list of all VM's with known snapshots |
Owner
There was a problem hiding this comment.
Comments should have a space after #.
| } | ||
| } | ||
|
|
||
| #Get all VM's with delta disks |
| $icount = $final.count - $snapshotfinal.count | ||
| Write-Output "Total number of VM's with visible snapshots: $vcount" | ||
| write-output "Total number of VM's invisible snapshots: $icount" | ||
| write-output "`nYou have hidden snapshots on the follow VM's:`n" |
Owner
There was a problem hiding this comment.
This should only print if a hidden snapshot is found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've created a new function that will check for all VM snapshots, hidden or not, and report on them. Take a look at and let me know if any changes are needed. I tried to follow the existing standards code wise in the rest of the functions.