WIP move store into fork-choice#53
Draft
dapplion wants to merge 1 commit into
Draft
Conversation
dapplion
force-pushed
the
move-store-into-forkchoice
branch
from
28a3f9d to
3d50605
Compare
dapplion
changed the base branch from
fork-choice-optimistic-mode
to
unstable
dapplion
force-pushed
the
move-store-into-forkchoice
branch
from
b3bac1e to
791dbd3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converting an anchor into ForkChoiceStore is very sensitive logic since you decide what you set the justified and finalized checkpoints to. It's odd that this piece of critical logic is left to the implementors of the trait ForkChoiceStore. This trait was meant originally to not add
storecomplexity into the fork-choice crate.This PR introduces a
BalancesGettertrait to still leave to consumers the responsability to deal with the store but move the ForkChoiceStore initialization logic to the fork-choice crate.It's a bit lengthy as the persistance of the fork-choice store has to move to the other crate and all setters and getters of the fc_store can be simplified.
TODO: