remove lighthouse_version from all library crate deps#63
Open
dapplion wants to merge 1 commit into
Open
Conversation
Thread version strings from top-level binaries into library crates via config structs and Context objects. This eliminates cargo cache invalidation on every git commit caused by git_version!() macro. lighthouse_version now only appears as a [dependency] in the lighthouse and lcli binaries, and as a [dev-dependency] in beacon_chain (for test assertions).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thread version strings from top-level binaries into library crates via config structs and Context objects. This eliminates cargo cache invalidation on every git commit caused by git_version!() macro.
lighthouse_version now only appears as a [dependency] in the lighthouse and lcli binaries, and as a [dev-dependency] in beacon_chain (for test assertions).
Issue Addressed
Which issue # does this PR address?
Proposed Changes
Please list or describe the changes introduced by this PR.
Additional Info
Please provide any additional information. For example, future considerations
or information useful for reviewers.