feat: bump @grpc/grpc-js minimum from ^1.9.3 to ^1.12.5#742
Draft
nelson-parente wants to merge 1 commit intodapr:mainfrom
Draft
feat: bump @grpc/grpc-js minimum from ^1.9.3 to ^1.12.5#742nelson-parente wants to merge 1 commit intodapr:mainfrom
nelson-parente wants to merge 1 commit intodapr:mainfrom
Conversation
Raise the @grpc/grpc-js floor version to 1.12.5 which includes: - Node.js 22 LTS compatibility fixes - Improved channel connectivity state management - Better error messages for connection failures - Performance improvements in call credential handling The previous ^1.9.3 range technically resolves to 1.14.3 via semver, but the low floor allowed installing versions with known issues on Node 22. Bumping to ^1.12.5 ensures a minimum version that is tested and stable on Node 22 LTS (used in CI). Signed-off-by: Nelson Parente <nelson_parente@live.com.pt>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #742 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 6 6
Branches 1 1
=========================================
Hits 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@grpc/grpc-jsminimum from^1.9.3to^1.12.5package-lock.json(resolves to 1.14.3)Motivation
The previous
^1.9.3floor allowed installing grpc-js versions with known issues on Node.js 22 LTS. While semver already resolves to 1.14.3, the low floor is misleading — it implies 1.9.x is a supported baseline. Bumping to^1.12.5documents the actual minimum tested version and ensures:Test plan
npm installto verify dependency resolutionnpm run test:unit:allto verify no regressions