chore: skip own PR Discord notifications#2
Merged
Conversation
Skip Discord notifications for pull request events when the PR author or sender is the configured ignored GitHub actor. This keeps PR notifications focused on activity from other users.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Self-authored pull request notifications add noise to the Discord channel when the useful signal is activity from other users.
What Changed
The Discord notification workflow now defines
IGNORED_PR_ACTORand exits early for pull request events when either the PR author or event sender matches that actor.Issue, release, star, and default-branch workflow failure notifications are unchanged.
Flow
flowchart LR PREvent[Pull request event] --> ReadActor[Read PR author and sender] ReadActor --> Own{Matches ignored actor?} Own -- yes --> Skip[Skip Discord notification] Own -- no --> Notify[Post Discord notification]Test Plan
git diff origin/main...HEAD --checkruby -e 'require "yaml"; YAML.load_file(ARGV[0])' .github/workflows/discord-notifications.ymlShellCheck was not available in the local environment.