Fix evolve state mismatch on evolution failure and preserve manual build rollback ability after AI change rollback#40
Draft
Cas Linden (CasLinden) wants to merge 1 commit intomainfrom
Conversation
📋 PR Overview
|
…ate fallthrough on evolution failure
9faeb8a to
48c5243
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan
Preserve rollback
Make a manual change, build it.
Try evolving, -> discard -> can still roll back build
Failed evolution
Make a manual change
Enter a prompt -> cancel before it finishes
Repo changes are restored,
~/Library/Application\ Support/com.darkmatter.nixmac/evolve-state.json-> reflects manual not evolve.Caveat: this takes a watcher tick to fully resolve. Evolution errors do not return new evolve state object on failure. They pretend like nothing ever changed, which is good, but also why this fell through and was hard to find/fix.
Docs