Cas/reset evolve state on dirchange ENG-441#46
Open
Cas Linden (CasLinden) wants to merge 4 commits intomainfrom
Open
Cas/reset evolve state on dirchange ENG-441#46Cas Linden (CasLinden) wants to merge 4 commits intomainfrom
Cas Linden (CasLinden) wants to merge 4 commits intomainfrom
Conversation
📋 PR Overview
|
1f2f818 to
ff1f4cb
Compare
Scott McMaster (scottmcmaster)
approved these changes
Apr 24, 2026
1643080 to
d425c19
Compare
…select, also return state and hosts
…p path and improve bootstrap and dir picker UX with enter key and readable local form erros
d425c19 to
7e6ffe7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SetDirResult { dir, evolveState?, hosts? }fromconfig_set_dir/config_pick_dir— frontend applies evolve state and host list immediately without extra round tripsBootstrapConfigdetects whetherflake.nixexists and whether the repo has any commits — offers "Make initial commit" instead of failing when a flake is present but uncommittedbootstrap_default_confighandles existingflake.nix— commits it in place rather than returning "directory is not empty"Test Plan
flake.nixand no git commits → "Make initial commit" button shown (not "Create Default Configuration")darwinConfigurationflake.nix→ bootstrap shows "Create Default Configuration" (not commit variant)