Skip to content

DO NOT MERGE: Intentional E2E failure validation#47

Closed
Farhan (fkb032) wants to merge 19 commits intomainfrom
fkb/e2e-intentional-failure-test-pr
Closed

DO NOT MERGE: Intentional E2E failure validation#47
Farhan (fkb032) wants to merge 19 commits intomainfrom
fkb/e2e-intentional-failure-test-pr

Conversation

@fkb032
Copy link
Copy Markdown
Contributor

DO NOT MERGE

This is an intentional E2E failure validation PR.

It deliberately changes the settings button aria-label so the settings_provider_change E2E scenario fails. The expected result is a failing nixmac E2E PR comment that includes:

  • failed scenario status
  • failure text
  • embedded failure screenshot
  • linked webview flow recording
  • full HTML report link

Test Plan

Do not merge. Confirm the nixmac E2E sticky comment reports settings_provider_change as failed and includes visual proof.

@fkb032 Farhan (fkb032) added the e2e:scenario:settings_provider_change Run only the settings_provider_change E2E scenario label Apr 23, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 23, 2026

nixmac E2E

Status: failed

Reason: required: scenario label present

Tested commit: 80bb4386e7adfd010fa813779f2d1425d893d040

Scenario Lane Result Report Proof Replay
settings_provider_change tauri-wdio failed https://releases.nixmac.com/e2e/pr-47/80bb4386e7adfd010fa813779f2d1425d893d040/settings_provider_change/index.html Flow recording (webview) bun run test:wdio:smoke

Failure: settings_provider_change

Phase: opens and navigates all tabs

Error: Timed out waiting for selector: button[aria-label="Settings"]

Failure proof

Failure video (webview flow recording)

Full HTML report

Workflow run

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 23, 2026

Fails
🚫

New Rust modules were added without tests. Add a #[cfg(test)] mod tests { … } block or a file under apps/native/src-tauri/tests/:

  • apps/native/src-tauri/src/e2e_support.rs
🚫

This PR touches behavior-sensitive code that is documented in darkmatter/nixmac-web. Please either:

  • Open a companion docs PR and check Docs updated in the PR description, or
  • Check No docs update needed if the change doesn't affect user-facing behavior.
Warnings
⚠️ PR is marked WIP / draft — do not merge until ready for review.
⚠️ Please assign this PR to someone (usually yourself).
⚠️ ❗ Big PR (5616 lines changed). Consider splitting it into smaller, focused changes.
⚠️

New TypeScript source files were added without any new tests:

  • apps/native/src/utils/e2e-proof-mode.ts
Messages
📖

🤖 This PR touches CI / infra — reviewers please pay extra attention:

  • .github/workflows/e2e.yml

📋 PR Overview

Lines changed 5616 (+5448 / -168)
Files 36 added, 35 modified, 0 deleted
Draft / WIP yes
Has Test Plan yes
New UI components no
New Storybook stories no
New Rust modules yes (1)
New TS source files yes (1)
New tests no
package.json touched yes
Cargo.toml touched no
Infra / CI touched yes

Generated by 🚫 dangerJS against 80bb438

@fkb032
Copy link
Copy Markdown
Contributor Author

Closing this validation-only PR. It intentionally broke the settings E2E scenario to prove failure reporting with screenshot/video/report links; that evidence is preserved in the closed PR comments and Actions run. Keeping #45 as the single live E2E gate validation PR.

@fkb032 Farhan (fkb032) deleted the fkb/e2e-intentional-failure-test-pr branch April 24, 2026 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

e2e:scenario:settings_provider_change Run only the settings_provider_change E2E scenario

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants