[codex] Hide direct OpenAI settings option#49
Open
Farhan (fkb032) wants to merge 1 commit intomainfrom
Open
Conversation
📋 PR Overview
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OpenAI / OpenRoutertoOpenRouterai-models-tabsubscription cleanup while touching the same surfaceWhy
We no longer want to advertise direct OpenAI as a normal first-class path in the main UI, but we also do not want this PR to do a broader provider refactor. This keeps the visible settings surface OpenRouter-first while preserving the existing backend/store fallback behavior.
Known Limitation
Users with only a legacy saved direct OpenAI key are still in an intermediate state until #38 lands: the UI now says
OpenRouter, but backend fallback can still route them to direct OpenAI and the model list is still driven by the OpenRouter catalog.Reviewer Note
The
return subscriptionchange inai-models-tab.tsxis intentional. Claude review verified thatform.store.subscribe(...)returns the unsubscribe function directly, so the previous.unsubscribe()cleanup path was incorrect.Test Plan
bunx oxlint apps/native/src/components/widget/settings/api-keys-tab.tsx apps/native/src/components/widget/settings-dialog.tsx apps/native/src/components/widget/settings/ai-models-tab.tsxbun run --cwd apps/native build(still fails on pre-existing unrelated TypeScript/dependency issues in kibo-ui/monaco files; no remaining errors in the touched settings files)Docs