[AI] Move segmentation from src/ai to src/common/ai for consistency#20542
Merged
TurboGit merged 1 commit intodarktable-org:masterfrom Mar 16, 2026
Merged
[AI] Move segmentation from src/ai to src/common/ai for consistency#20542TurboGit merged 1 commit intodarktable-org:masterfrom
TurboGit merged 1 commit intodarktable-org:masterfrom
Conversation
andriiryzhkov
changed the title
TurboGit
added
priority: high
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just a refactoring, no new functionality introduced.
Rationale
Establishes a clean separation between the two AI layers:
src/ai/- pure ONNX Runtime backend (backend.h,backend_common.c,backend_onnx.c). Self-contained, no darktable core dependencies. Builds asdarktable_aistatic library.src/common/ai/- higher-level AI modules that bridge the AI backend with darktable core. Compiled conditionally (USE_AI=ON) as part of the mainlib_darktabletarget.This ensures that any AI module in
src/common/ai/can freely use darktable core APIs without introducing cross-library link dependencies - which would break the Windows build where the linker is stricter about unresolved symbols in static libraries.Aligns with the same refactoring done for
restore.cin PR #20523, moving all non-backend AI code tosrc/common/ai/for consistency and maintainability.