fix(plugin): register skills/commands in plugin.json and harden plugin-abilities#296
Open
darrenhinde wants to merge 2 commits intomainfrom
Open
fix(plugin): register skills/commands in plugin.json and harden plugin-abilities#296darrenhinde wants to merge 2 commits intomainfrom
darrenhinde wants to merge 2 commits intomainfrom
Conversation
…n-abilities (#285, #281) - Add skills (12) and commands (6) arrays to plugin.json so Claude Code discovers them (#281) - Fix external-scout → external-research naming throughout README - Add explicit name: frontmatter to 3 command files - Expand plugin-abilities types to cover all 5 step types (agent, skill, approval, workflow, script) with full Ability and ExecutorContext definitions - Rewrite executor to handle all step types with shell-escape interpolation to prevent command injection, prototype pollution guards, abort signal for cancellation, step output forwarding, and conditional execution - Add cancelActive/onSessionDeleted/get/list to ExecutionManager - Add null safety in plugin.ts getStepInstructions, clear stale state on re-initialize, remove redundant type casts Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- cancelActive() no longer double-aborts; delegates to cancel() which owns both abort signal and state mutation - onSessionDeleted() and cleanup() now abort the controller so in-flight execution loops actually stop - Set activeExecution before awaiting executeAbility so getActive() returns a live reference during execution (fixes chat-context injection) - Add early abort check in executeAbility before the step loop starts - opencode-plugin.ts uses cancelActive() instead of cancel() Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
skills(12) andcommands(6) arrays toplugin.jsonso Claude Code can discover themplugin-abilitiesprototype — expanded types, executor, and execution manager to be internally consistent and secure (note: the actualcommand3.agentcrash is in the OpenCode CLI binary, not this repo)external-scout→external-researchnaming throughout README, updated counts, added explicitname:frontmatter to 3 command filesTest plan
/oac:help,/brainstorm,/debug, etc./external-researchworks (not/external-scout)🤖 Generated with Claude Code