catch exception in wamp_session::send_msg in case of problems with underlying socket#83
Open
uquendo wants to merge 1 commit intodarrenjs:masterfrom
Conversation
Owner
|
Hi, I need to review this in a bit more in depth, because the call to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Catching write exception on the session it belongs to instead of propagating further (for example, to pubsub_man::update_topic) and possibly dropping the session that posted the data to the topic our problematic client is subscribed to.
Problem was observed when one slow subscriber (able to hit wampcc::default_socket_max_pending_write_bytes limit) was able to drop the sessions of all the publishers to the topics it is subscribed to.