-
Notifications
You must be signed in to change notification settings - Fork 103
[ffigen] Replace pub run with dart run #3000
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
PR HealthLicense Headers ✔️
All source files should start with a license header. Unrelated files missing license headers
This check can be disabled by tagging the PR with API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
This check can be disabled by tagging the PR with
Breaking changes
|
| Package | Change | Current Version | New Version | Needed Version | Looking good? |
|---|---|---|---|---|---|
| hooks | None | 1.0.0 | 1.0.0 | 1.0.0 | ✔️ |
| hooks_runner | None | 1.0.1 | 1.0.2-wip | 1.0.1 | ✔️ |
| jni | Breaking | 0.15.2 | 0.15.3-wip | 0.16.0 Got "0.15.3-wip" expected >= "0.16.0" (breaking changes) |
This check can be disabled by tagging the PR with skip-breaking-check.
dcharkes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sigurdm I don't believe dart run works in a Flutter project with Flutter dependencies. IIRC the reason we have to do flutter pub run in some of these cases is because dart run will complain about there being flutter dependencies. This applies specifically for when you try to run one of your dev dependencies that in the package graph doesn't actually depend on a flutter package, but the way that the package resolution works is that it's resolved for the whole workspace, and in JIT we compile all code, including the dependencies that require a Flutter SDK.
The CI is green, but the updated docs wouldn't actually work for our users, at least not in JNIgen afaik. (FFIgen for ObjC got recently migrated to build hooks, so that should no longer be a Flutter SDK.)
FYI @liamappelbe
pkgs/ffigen/CHANGELOG.md
Outdated
| - Size for ints can be specified using `size-map` in config. | ||
| - Options to disable using supported typedefs (e.g `uint8_t => Uint8`), sort bindings. | ||
| - Option to add a raw `preamble` which is included as is in the generated file. | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this? We're at version 19 or 20 already? LLM gone mad?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this an llm gone mad! Sorry
|
We can just add the skip-changelog label instead. |
|
@sigurdm You might want to search for |
Following up on dart-lang/pub#4737, this PR replaces deprecated
pub runcommands withdart run.