Skip to content

Conversation

@sigurdm
Copy link

@sigurdm sigurdm commented Jan 22, 2026

Following up on dart-lang/pub#4737, this PR replaces deprecated pub run commands with dart run.

@sigurdm sigurdm marked this pull request as ready for review January 22, 2026 12:19
@github-actions
Copy link

github-actions bot commented Jan 22, 2026

PR Health

License Headers ✔️
// Copyright (c) 2026, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/hooks_runner/test_data/download_assets/hook/build.dart
pkgs/jni/test/debug_release_test.dart
pkgs/objective_c/example/command_line/lib/main.dart
pkgs/objective_c/lib/src/ns_input_stream.dart

This check can be disabled by tagging the PR with skip-license-check.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbol Leaking sources

This check can be disabled by tagging the PR with skip-leaking-check.

Breaking changes ⚠️
Package Change Current Version New Version Needed Version Looking good?
hooks None 1.0.0 1.0.0 1.0.0 ✔️
hooks_runner None 1.0.1 1.0.2-wip 1.0.1 ✔️
jni Breaking 0.15.2 0.15.3-wip 0.16.0
Got "0.15.3-wip" expected >= "0.16.0" (breaking changes)
⚠️

This check can be disabled by tagging the PR with skip-breaking-check.

@coveralls
Copy link

coveralls commented Jan 22, 2026

Coverage Status

coverage: 81.786%. remained the same
when pulling fda6687 on sigurdm:remove-pub-run
into d296579 on dart-lang:main.

Copy link
Collaborator

@dcharkes dcharkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sigurdm I don't believe dart run works in a Flutter project with Flutter dependencies. IIRC the reason we have to do flutter pub run in some of these cases is because dart run will complain about there being flutter dependencies. This applies specifically for when you try to run one of your dev dependencies that in the package graph doesn't actually depend on a flutter package, but the way that the package resolution works is that it's resolved for the whole workspace, and in JIT we compile all code, including the dependencies that require a Flutter SDK.

The CI is green, but the updated docs wouldn't actually work for our users, at least not in JNIgen afaik. (FFIgen for ObjC got recently migrated to build hooks, so that should no longer be a Flutter SDK.)

FYI @liamappelbe

- Size for ints can be specified using `size-map` in config.
- Options to disable using supported typedefs (e.g `uint8_t => Uint8`), sort bindings.
- Option to add a raw `preamble` which is included as is in the generated file.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this? We're at version 19 or 20 already? LLM gone mad?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this an llm gone mad! Sorry

@sigurdm sigurdm changed the title Replace pub run with dart run [ffigen] Replace pub run with dart run Jan 22, 2026
@dcharkes
Copy link
Collaborator

We can just add the skip-changelog label instead.

@dcharkes
Copy link
Collaborator

@sigurdm You might want to search for "pub" and 'pub' in the repo as well to see if there aren't any Process.run invocations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants