fix(ui): clear startup transient error banners once network/migration is ready

[Claudius-Maginificent]

TL;DR: Keep the "storage still updating" banner visible until storage is genuinely free again, instead of letting it disappear about a frame too early.

User story

As a user who just finished the app's first-run migration, I want the "storage update is still running" message to stay up until storage is truly available, so a retried action that fails during that window isn't left unexplained.

Scenario

Base flow

The app finishes cold-start migration; the user immediately retries a wallet-touching action.

Actual behavior

Two error banners could persist indefinitely during app cold start ("storage update is still running" and a masternode-list-not-yet-synced error) — even minutes after the underlying condition fully resolved. The initial fix for that made the storage banner reactive, but it could still clear about one frame before storage was actually free: a background best-effort node-list refresh kept holding the lock past the point the migration state reported "ready." A retry in that narrow window failed again with the banner already gone, looking like an unexplained glitch.

Expected behavior

Both banners clear reactively once their condition is genuinely resolved, and the storage banner specifically stays up until storage is truly free — so a failed retry in that window has a visible, honest explanation instead of none.

Detailed discussion

What was done

• Added a dedicated TaskError::MasternodeListNotReady variant with a clean, actionable message instead of falling through to the generic, opaque SdkError text.
• ConnectionBanner/MigrationReconciler (app/reconcilers.rs) now adopt these banner handles and clear them reactively once their readiness condition genuinely holds, instead of leaving them disable_auto_dismiss()'d forever.
• Review fix: storage_guard_resolved was computed from MigrationState alone, so it could flip true (and clear the banner) before the migration_run mutex the error actually reports on was released — a detached best-effort DAPI-node refresh keeps holding it past MigrationState going Ready. Gated the clear on both the terminal state AND a non-blocking migration_run.try_lock() probe.
• Extracted the repeated adopt/reset/conditional-clear banner-handle pattern (shared by ConnectionBanner and MigrationReconciler) into a small TransientBanner newtype — same behavior, less duplication.
• Hardened the SDK error-string sentinel test to pin the literal upstream string shape (instead of round-tripping the same constant through itself), and cross-referenced the producer/consumer sites of that string so the coupling between context_provider.rs and backend_task/error.rs is discoverable.
• Addresses claudius:grumpy-review findings CODE-001 (blocking), CODE-003 and PROJ-001 (non-blocking). CODE-002 (a pre-existing FIFO-eviction edge case in the "stuck offline forever" scenario) is a known, accepted follow-up — not fixed here.

Testing

• New/updated reconciler + error-mapping tests (banner-clears-when-ready, plus the new guard/lock-aware clearing) — all green via the narrowest relevant --lib scope.
• cargo clippy --bin dash-evo-tool --all-features -- -D warnings clean, cargo fmt --all clean.
• Independently re-verified by qa-engineer-marvin during grumpy-review consolidation.

Breaking changes

None.

Checklist

• Tests added (TDD)
• User-facing strings are plain, complete sentences
• No secrets in diff

Prior work

• Addresses findings from the combined grumpy-review of PR fix(ui): clear startup transient error banners once network/migration is ready #916/fix(ui): pointer cursor + tooltips on nav; indicate wallet-less masternodes #917/feat(identity): pending DPNS registration indicator, hint-text sizing, and social-profile fixes #918.

Attribution

_{🤖 Co-authored by Claudius the Magnificent AI Agent}

[coderabbitai]

📝 Walkthrough

Walkthrough

The change classifies masternode-list startup failures, routes storage and quorum readiness errors to dedicated banner trackers, and clears those banners when migration or masternode readiness is restored.

Changes

Startup readiness handling

Layer / File(s)	Summary
Quorum readiness error classification src/context_provider.rs, src/backend_task/error.rs	A shared SDK diagnostic identifies masternode-list startup failures and maps them to TaskError::MasternodeListNotReady, with unit-test coverage.
Startup banner tracking and clearing src/app.rs, src/app/reconcilers.rs	AppState tracks storage and quorum startup banners through the appropriate reconcilers, which clear them after readiness or migration resolution. Tests cover both clearing paths.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant SpvProvider
  participant TaskError
  participant AppStateUI
  participant ConnectionBanner
  participant MigrationReconciler
  SpvProvider->>TaskError: emit masternode-list-not-ready diagnostic
  TaskError->>AppStateUI: classify as MasternodeListNotReady
  AppStateUI->>ConnectionBanner: track quorum startup banner
  AppStateUI->>MigrationReconciler: track storage startup banner
  ConnectionBanner->>ConnectionBanner: clear when masternodes become ready
  MigrationReconciler->>MigrationReconciler: clear when storage migration resolves

Loading

Suggested labels: claudius-review

Suggested reviewers: lklimek

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly summarizes the main fix: clearing startup error banners when network or migration readiness is reached.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/startup-transient-error-banners

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[thepastaclaw]

🕓 Ready for review — 39 ahead in queue (commit 841b70d)
Queue position: 40/40

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/app/reconcilers.rs`:
- Around line 517-525: The storage_guard_resolved check in the migration state
handling must exclude transient backend-not-ready failures from being considered
resolved. Update the logic around MigrationState::Failed and
error.is_backend_not_ready() so the storage_startup_error banner is retained
while automatic retry resets the migration state to Idle; continue clearing it
for genuinely resolved states and non-transient failures.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: a87a1a98-7a1b-48d4-a361-5c27cdf963c0

📥 Commits

Reviewing files that changed from the base of the PR and between 0812761 and 9ac720a.

📒 Files selected for processing (4)

• src/app.rs
• src/app/reconcilers.rs
• src/backend_task/error.rs
• src/context_provider.rs

[coderabbitai]

🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Prevent premature banner clearance during transient migration failures.

If the migration fails transiently due to a slow-wiring backend (error.is_backend_not_ready()), the frame state evaluates to MigrationState::Failed. This satisfies storage_guard_resolved, prematurely clearing the user's active startup error banner. Immediately after, the failure match-arm below resets the migration status back to Idle for a seamless background retry, but the banner is already lost.

To ensure the "storage not ready" warning remains visible to the user while the automatic retry happens, storage_guard_resolved should not treat transient failures as resolved.

🐛 Proposed fix

-        let storage_guard_resolved = !matches!(
-            &state,
-            MigrationState::Idle
-                | MigrationState::Running { .. }
-                | MigrationState::AwaitingWalletPasswords { .. }
-        );
+        let is_transient_failure = match &state {
+            MigrationState::Failed { error }
+            | MigrationState::FailedWithUnreadableIdentities { error, .. } => {
+                error.is_backend_not_ready()
+            }
+            _ => false,
+        };
+        let storage_guard_resolved = !is_transient_failure
+            && !matches!(
+                &state,
+                MigrationState::Idle
+                    | MigrationState::Running { .. }
+                    | MigrationState::AwaitingWalletPasswords { .. }
+            );
         if storage_guard_resolved && let Some(handle) = self.storage_startup_error.take() {
             handle.clear();
         }

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	let storage_guard_resolved = !matches!(
	&state,
	MigrationState::Idle
	| MigrationState::Running { .. }
	| MigrationState::AwaitingWalletPasswords { .. }
	);
	if storage_guard_resolved && let Some(handle) = self.storage_startup_error.take() {
	handle.clear();
	}
	let is_transient_failure = match &state {
	MigrationState::Failed { error }
	| MigrationState::FailedWithUnreadableIdentities { error, .. } => {
	error.is_backend_not_ready()
	}
	_ => false,
	};
	let storage_guard_resolved = !is_transient_failure
	&& !matches!(
	&state,
	MigrationState::Idle
	| MigrationState::Running { .. }
	| MigrationState::AwaitingWalletPasswords { .. }
	);
	if storage_guard_resolved && let Some(handle) = self.storage_startup_error.take() {
	handle.clear();
	}

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/app/reconcilers.rs` around lines 517 - 525, The storage_guard_resolved
check in the migration state handling must exclude transient backend-not-ready
failures from being considered resolved. Update the logic around
MigrationState::Failed and error.is_backend_not_ready() so the
storage_startup_error banner is retained while automatic retry resets the
migration state to Idle; continue clearing it for genuinely resolved states and
non-transient failures.