Open
Conversation
added 2 commits
September 11, 2023 15:44
Collaborator
|
@ktechmidas please test this and verify logs are received in a useful format |
shumkov
requested changes
Oct 11, 2023
| - to: "log.level" | ||
| - rename: | ||
| fields: | ||
| - from: "json.span.height" |
Collaborator
There was a problem hiding this comment.
correct path will be json.spans.height. Why do you want to rename it?
There was a problem hiding this comment.
We want to rename it to have the same name as in tenderdash, to make filter/search easier
| - rename: | ||
| fields: | ||
| - from: "json.span.height" | ||
| - to: "json.height" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Issue of consistency with tenderdash fixed
What was done?
Renamed json.span.height to json.height and json.span.round to json.round in elastic for consistency with Tenderdash
How Has This Been Tested?
N/T
Breaking Changes
None
Checklist:
For repository code-owners and collaborators only