Conversation
added 2 commits
August 12, 2024 06:48
shumkov
requested changes
Aug 12, 2024
Collaborator
shumkov
left a comment
There was a problem hiding this comment.
I see a lot of code duplication. It will be hard to maintain so you need to change same things in both places. I didn't get what is the actual difference. Also I think tags a more appropriate in this case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
This will run a quick update if you set the var, only set the var if the network is already deployed and just needs updating
What was done?
Added var for dashmate_quick_update and quick_update.yml with the basics
How Has This Been Tested?
Breaking Changes
None
Checklist:
For repository code-owners and collaborators only