Draft
Conversation
…ce instead of returning std::variant
- Rename IsKnownTx to HasTxForLock for clarity (returns true when the lock's transaction is known, not pending without a TX) - Fix unconditional LookupBlockIndex in CheckCanLock: only take cs_main on cache miss instead of every call - Fix log prefix typos: NetSigning -> NetInstantSend in ProcessInstantSendLock - Remove redundant LookupBlockIndex fallback in ProcessInstantSendLock that duplicated the static GetBlockHeight helper - Simplify AttachISLockToTx: use for-loop with early-continue, remove unnecessary variable - Remove double blank line Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…PackageSelection, final part)
There's new helper IsValidAndSynced in CGovernanceManager that incapsulate usages of CMasternodeSync in CMNPayment
…otifier is introduced to use it for CChainState
|
This pull request has conflicts, please rebase. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#depends on #7212
Issue being fixed or feature implemented
There's no real usages of spork3 in regression tests currently.
Spork3 doesn't have functional or regressions tests.
Sporks are disabled for main net.
Someday it may be useful for testnet, but [theoretically] it maybe already broken long time ago.
Should we still have it? Any thoughts?
PR is pretty trivial.
What was done?
Removed spork3 that does block filtering.
How Has This Been Tested?
Run unit & functional tests.
Breaking Changes
Spork3 is removed. Affected only devnets, testnet and regtest.
Checklist: