feat(wallet): integration DashDEX feat#818
Open
romchornyi wants to merge 67 commits into
Open
Conversation
Why: - improve SwapKit conversion UX and error surfacing across quote, preview, and submit flows What: - curate supported assets, preserve identifier casing, and expand chain coverage - split indicative quote fetching from full swap execution and improve preview refresh behavior - surface clearer fee and invalid destination address messaging, plus related UI/localization updates Validation: - full build/tests were not run in this session before committing
Why: - keep the current swap flow changes together in one commit - preserve the current project version state from the working tree What: - harden Maya and SwapKit pending, status, address, and validation flows - include the current project and localization updates that are part of the staged state Validation: - not run (not requested)
Why: - refine the SwapKit portal presentation and supporting assets - keep the current staged project wiring together with the ui update What: - update swap portal screens, copy, and illustrations - replace the svg portal illustration with png assets and include the current project file changes Validation: - not run (not requested)
Why: - reduce receive-target overshoot in swap previews - restore missing long-tail token icons in select-coin flow What: - use fixed-fee-aware gross-up and preview convergence for receive-target quotes - keep preview purchase amount anchored to the entered target - load remote token icons from the SwapKit CDN with jsupa fallback - update swapkit-related image assets used by the flow Validation: - git diff --cached --stat - git diff --check on updated swap files - swiftc -parse on updated Swift files - xcodebuild -list -project DashWallet.xcodeproj
Add isConfirming flag to prevent multiple confirmations when rapidly tapping Continue. Re-arm flag when returning from previous screen and in error cases. Add guard in SwapFlowCoordinator to prevent duplicate ConvertVC navigation.
- Import and use DashUIKit components (NavigationBar, MenuItem, MenuViewModifier) - Update color references to use DashUIKit theming (Color.dash.primaryBackground) - Refactor action cards to use DashUIKit MenuItem component - Update styling to use MenuViewModifier for consistent appearance
- Remove FrameReader, LocationReader, ScrollViewWithOnScrollChanged from project - Remove SearchBar component (now in DashUIKit) - Update LocalCurrencyView to use DashUIKit components - Update SelectCoinView to use DashUIKit components - Update project configuration for DashUIKit integration
- Remove DashSwitch and RadioButtonRow (now in DashUIKit) - Remove CoinRowView component - Update POIDetailsView to use DashUIKit components - Update MerchantFiltersView with DashUIKit integration - Update TerritoryPickerView with new component structure - Update TransactionFilterDialog to use DashUIKit components - Update SelectCoinView with DashUIKit imports and usage - Update project configuration for new dependencies
- Remove ErrorIllustration, LoadingIllustration, SuccessIllustration (now in DashUIKit) - Remove HaltedToast component (replaced by DashUIKit Toast) - Update SelectCoinView to use DashUIKit Toast component - Update SwapTransactionFailureView with DashUIKit Toast and ErrorIllustration - Update SwapTransactionPendingView with DashUIKit LoadingIllustration - Update SwapTransactionSuccessView with DashUIKit Toast and SuccessIllustration - Update project configuration for new component structure
- Remove AddressFieldView from project (now in DashUIKit) - Update EnterAddressView to use DashUIKit AddressFieldView component - Update SelectCoinView with DashUIKit integration - Update project configuration for new component structure
- Remove DashBalanceView, DashPickerView, EnterAmountView, SwapAmountView (now in DashUIKit) - Remove ScaleToFitWidth geometry utility (now in DashUIKit) - Update SwapConvertView to use DashUIKit EnterAmount component - Update SwapConvertViewModel to work with new component structure - Update project configuration for DashUIKit integration
- Remove NumericKeyboardView from project (now in DashUIKit) - Update DashSpendSinglePanel to use DashUIKit NumericKeyboardView - Update DashSpendUserAuthScreen to use DashUIKit NumericKeyboardView - Update project configuration for new component structure
- Update SwapConvertView with refined component structure - Update SwapConvertCardRow with new styling - Update OrderPreviewView and related components - Update OrderPreviewFeeRow and OrderPreviewTableRow - Update SwapFeeInfoSheet component - Update SelectCoinView with improvements - Update SwapTransactionStatusHostingController - Update SwapTransactionFailureView, SwapTransactionPendingView, SwapTransactionSuccessView - Integrate latest DashUIKit components and styling
…der routing Implement DashDEX feature entry-point with protocol-driven swap provider dispatch: - Add SwapDirection enum (buy/sell) for directional swap flows - Add RouteProvider protocol for swap provider selection logic - Implement SwapKit and Maya as SwapProvider conformers via protocol requirements - Update SwapBackend to dispatch based on protocol requirements, not extension fallbacks - Migrate Maya coin icons to dynamic loading with fallback UI support - Remove static Maya coin PNG assets (now loaded from API) - Add DashDEX entry icons and illustrations to asset catalog This ensures SwapKit overrides work correctly through proper protocol dispatch instead of being skipped by static method resolution.
Update Maya and Swap UI components with improved icon handling and display: - Refactor MayaCoinIconLoader for dynamic icon loading with fallback support - Update MayaCryptoCurrency icon mapping for efficient loading - Enhance SwapProvider protocol with better icon URL handling - Update SwapKitModels for improved asset representation - Optimize SwapKitSwapProvider icon URL construction - Improve SwapCoinIconView with better fallback UI - Update SelectCoinViewModel with enhanced icon loading logic - Refine SwapPortalScaffold UI layout - Update MayaPortalView for better icon display - Improve ShortcutAction with DashDEX shortcut icon - Add shortcut-dash-dex PNG assets to asset catalog - Update project configuration for asset changes
… integration Improve swap UI components and Maya provider icon loading: - Enhance MayaCryptoCurrency icon mapping with better fallback support - Optimize SwapKitSwapProvider icon URL handling - Improve SwapCoinIconView with better image loading and fallback UI - Update SelectCoinViewModel with enhanced icon loading logic - Refine SwapKitPortalView icon display - Update project configuration This improves the user experience when displaying swap provider icons and coin assets.
… flow - Enhance MayaCryptoCurrency with buy operation support - Update project.pbxproj with buy flow component references - Add support for deposit address resolution and refund handling
- Remove MayaAddressValidator (merged into MayaSwapProvider) - Remove MayaCoinIconLoader (now handled by dynamic icon loading) - Remove MayaCryptoCurrency (consolidated in provider models) - Remove MayaExchangeAddressProvider (functionality in SwapProvider) - Remove MayaPool (address management in provider) - Remove MayaSwapPendingGate (transaction tracking in service) - Cleanup legacy Maya model separation
…roviders - Enhance SwapProvider with consolidated address validation and deposit routing - Improve SwapDepositURIBuilder for provider-agnostic URI generation - Consolidate MayaSwapProvider with address validator functionality - Improve SwapKitSwapProvider with cross-chain routing logic - Reduce model fragmentation by moving logic to protocol implementations
…alidation - Enhance BuyEnterAmountView with provider selection and amount validation - Improve BuyEnterAmountViewModel with deposit address generation - Refine BuyReceiveView for transaction tracking and clipboard support - Improve BuyReceiveViewModel with polling and completion handling - Enhance RefundAddressView with better UX and validation feedback - Refine RefundAddressViewModel for NEAR address handling - Update all hosting controllers for proper lifecycle management
- Enhance SwapConvertView with better provider routing and amount display - Improve SwapConvertViewModel for provider-specific formatting - Refine EnterAddressView with consolidated validation logic - Improve EnterAddressViewModel using SwapProvider protocol methods - Update hosting controllers for consistent lifecycle handling - Remove dependency on deleted Maya standalone models
…provements - Enhance OrderPreviewView for buy/sell flow display - Improve OrderPreviewViewModel with buy amount calculation - Update SelectCoinView for better provider routing - Improve SelectCoinViewModel using SwapProvider protocol methods - Enhance SwapCoinIconView with dynamic icon fallbacks - Update SelectCoinHostingController for lifecycle management - Remove dependency on deleted Maya models
- Update SendCoinsService to use SwapProvider protocol methods - Enhance MayaAPIService for provider-driven requests - Improve Coinbase integration with new provider routing - Remove MayaAddressValidatorTests (functionality moved to providers) - Remove MayaExchangeAddressLookupContextTests (consolidated in tests) - Update all services to use new protocol-based swap provider interface
- Update project.pbxproj to remove deleted Maya model references - Remove test file references for consolidated tests - Enhance SwapFlowCoordinator with updated provider routing - Update build configuration for cleaner module separation
- Add ExchangeAddressProvider protocol for provider-agnostic address resolution - Add SwapAddressValidator for consolidated address validation - Add SwapCoinIconLoader for dynamic icon loading - Add SwapCryptoCurrency for unified crypto currency handling - Add SwapPendingGate for transaction state tracking - Add SwapPool for liquidity pool representation - Add test coverage for address validation and exchange lookup - Create abstraction layer for multi-provider swap support
- Detect noRoutesFound error and show minimum amount message - Provide user-friendly error messages for swap failures - Handle edge cases in amount validation with proper localization
…ting - Enhance SwapBackend for better provider dispatching - Improve SwapDepositURIBuilder with better error handling - Refine SwapKitSwapProvider for cross-chain deposit routing
- Enhance BuyEnterAmountViewModel with better validation - Improve BuyReceiveView with enhanced message display - Refine BuyReceiveViewModel for better state management - Update RefundAddressViewModel with improved error handling
- Update CURRENT_PROJECT_VERSION to 14 for all targets - All targets (dashwallet, dashpay, TodayExtension, WatchApp) at 8.6.1 (14) - Maintain consistency across all build configurations
…tor routing - Improve SwapDepositURIBuilder with better error handling - Enhance BuyEnterAmountViewModel validation and error messages - Add message display improvements to BuyReceiveView - Refine BuyReceiveViewModel for better state handling - Simplify RefundAddressViewModel logic - Update SwapFlowCoordinator for improved routing
…ndling - Enhance SwapAddressValidator with better address validation - Improve SwapCryptoCurrency for consistent currency handling - Refine SwapDepositURIBuilder for accurate deposit address generation
- Enhance BuySellPortalView with better layout and navigation - Improve ShortcutsBarView for better shortcut display - Refine BuyReceiveView with better UX and messaging - Update RefundAddressView for NEAR address handling - Improve SelectCoinView with better coin selection UX - Enhance SwapPortalScaffold for consistent portal layout
- Enhance SwapKitQuoteDecodingTests for better quote validation - Add BuyReceiveFlowUITests for buy flow screenshot testing - Comprehensive test coverage for swap operations
- Update .gitignore for build artifacts - Update project.pbxproj with test file references - Maintain DWUpholdMainnetConstants.m configuration - Ensure clean build environment
- Add SwapOrder model and SwapOrdersDAO for transaction tracking - Implement SwapTrackingService for monitoring swap status - Add SwapOrderMetadataProvider for displaying swap metadata in transactions - Implement NetworkStatusService for connectivity monitoring - Add database migration for swap_orders table - Enhance SwapProvider protocol with provider-specific implementations - Update BuyEnterAmountView, BuyReceiveView, RefundAddressView with improved UX - Improve SwapConvertView and order preview flow - Update HomeView with swap order metadata display - Enhance MayaPortalView and SwapKit integration
DWUpholdMainnetConstants.m was committed with real Uphold clientID/clientSecret (populated locally by the Release build phase). Restore it to master's blanked (@"") state; real values belong only in the out-of-repo DWUpholdMainnetConstants__Release.m. The leaked secret must be rotated separately in the Uphold developer dashboard. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…transfer icons - SwapTrackingService: route-aware status polling and expiry handling - SwapBuyTransactionMatcher: precise buy DASH-arrival matching (amount+time+received) - SwapOrderMetadataProvider: guard against mislabeling non-DEX receives as "Converted" - CoinbaseMetadataProvider: Coinbase transfer tx icon via service tagging - SwapOrdersDAO: actor-based serialization - OrderPreview / Convert / Buy flow refinements Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Processing shows a text label only; completed shows nothing extra; failed (refunded/failed/expired) shows the error corner badge. Drops the ellipsis placeholder badge for pending states.
fix(ui): address review findings and improve UI contrast
feat(wallet): DashDEX ui and logic improvements
feat(wallet): implement DashDEX buy flow with transaction submission
|
Important Review skippedToo many files! This PR contains 171 files, which is 121 over the limit of 50. To get a review, narrow the scope: Upgrade to a paid plan to raise the limit. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (28)
📒 Files selected for processing (208)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
What was done?
How Has This Been Tested?
Breaking Changes
Checklist:
For repository code-owners and collaborators only