feat(ui): redesign all merchant locations experience#820
Conversation
Why: - consolidate the local explore redesign work into a single reviewable changeset - keep the where-to-spend and all-locations flows aligned after the sheet, navigation, and pagination updates - bump the build number to 14 for the next app build What: - add custom where-to-spend navigation bar assets and related SwiftUI navigation updates - finalize merchant details and all-locations redesign flows, including native sheet behavior and map integration - add paginated all-locations loading, real total counts, infinite scroll, and segmented-bar visibility fixes - update project build settings to 8.6.0 (14) Validation: - build was not reliably runnable in this environment because xcodebuild was blocked by CoreSimulatorService issues
Why: - keep paginated all-locations results deterministic across pages - preserve the current radius when navigating between all-locations and details What: - add a stable secondary sort for all-locations pagination - validate coordinates in the all-locations count path - pass the current search radius back into merchant details - narrow POIDetailsViewController initializer visibility to internal Validation: - no reliable xcodebuild validation was available in this environment because CoreSimulatorService remained unavailable
…difier Update Explore Dash database layer and clean up unused UI components: - Optimize ExploreDatabaseConnection query performance - Remove SelfSizingSheetModifier (consolidated into unified sheet infrastructure) - Update bridging header configuration - Update project configuration This improves database efficiency in the all-locations redesign.
romchornyi
changed the title
|
Warning Review limit reached
Next review available in: 35 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (27)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
2 participants
Issue being fixed or feature implemented
Redesigns the all merchant locations experience in Explore Dash. The previous list-only "all locations" screen is replaced with a redesigned, map-and-list experience and a dedicated "where to spend" navigation flow, along with supporting data-layer and merchant-details improvements.
What was done?
AllMerchantLocationsView,AllMerchantLocationsViewController, andAllMerchantLocationsViewModel, plus a newMerchantCellRow; the oldList/AllMerchantLocationsViewControlleris removed.POIDetailsViewController,POIDetailsView, andPOIDetailsViewModelreworked (significant simplification of the view controller).MerchantItemCell, updatedPointOfUseItemCell,MerchantListViewController,ExplorePointOfUseListViewController, and list model/data-provider changes.MerchantDAOimprovements (pagination behavior, coordinate validation),ExploreDatabaseConnectionandExploreDashupdates,ExplorePointOfUsepreview mocks.Approx. 1,842 insertions / 657 deletions across 32 files.
How Has This Been Tested?
Manual testing in the Explore Dash flow:
Breaking Changes
None.
Checklist:
For repository code-owners and collaborators only