fix(dashpay): resync before failing an accept whose request isn't in memory

[QuantumExplorer]

Summary

Accepting a pending contact request could fail with "Contact request not found" for a perfectly real request (QA repro: tap Accept on a pending row shortly after launch).

Root cause: the pending rows the Contacts screen renders come from SwiftData, which persists across sessions — but acceptContactRequest resolves the live ContactRequest handle from the SDK's in-memory state, which is per-session and only populated by a DashPay sync pass (15s background loop / explicit syncNow). Tapping Accept before this session's first pass lands → in-memory miss → bogus error.

Fix: on a miss, run one dashPaySyncNow pass and retry the lookup; only a miss after a fresh pass throws requestNotFound (genuinely revoked/consumed). The lookup is factored into a helper so both attempts share the exact same read.

Test plan

• Clean dashpay simulator build (arm64); installed on QA-iPhone16
• Fresh launch with a persisted pending request → Accept succeeds (resync path, "resyncing before accept" in the CONTACTS log category)
• Accept of a request revoked on-chain still errors after the resync

🤖 Generated with Claude Code

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ca2c2a7d-2195-4ab1-838d-06d7ca10061e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/accept-contact-request-resync

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}