Skip to content

fix(ui): register the ported explorer models in loadCounts#833

Merged
QuantumExplorer merged 1 commit into
swift-sdk-integrationfrom
fix/storage-explorer-counts
Jul 16, 2026
Merged

fix(ui): register the ported explorer models in loadCounts#833
QuantumExplorer merged 1 commit into
swift-sdk-integrationfrom
fix/storage-explorer-counts

Conversation

@QuantumExplorer

Copy link
Copy Markdown
Member

Summary

Follow-up to #832: the new explorer rows read their count badge from the counts dictionary, but loadCounts() was never taught about the ported models — so every new row showed 0 while its drill-in @Query list rendered the real records (QA repro: "Contact Requests 0" on the root list, 4 rows inside).

Registers all fifteen ported models (DashPay family ×7, pending inputs, asset locks, masternodes, shielded ×5) in loadCounts().

Test plan

  • Clean dashpay simulator build (arm64); installed on QA-iPhone16
  • Explorer root badges match the drill-in list counts (Contact Requests 4, Contact Profiles 1, DashPay Payments 3, Asset Locks 4, shielded rows non-zero)

🤖 Generated with Claude Code

The DashPay / asset-lock / masternode / shielded rows added in #832
read their badge from the counts dictionary, but loadCounts() was never
taught about their models — every new row showed 0 while its drill-in
@query list rendered the real records (QA: "Contact Requests 0" outside,
4 rows inside). Count all fifteen ported models.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ae25ca76-f90b-453b-8fd8-8aed780b5364

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/storage-explorer-counts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@QuantumExplorer
QuantumExplorer merged commit d9ac1fc into swift-sdk-integration Jul 16, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant