fix(ui): register the ported explorer models in loadCounts#833
Merged
QuantumExplorer merged 1 commit intoJul 16, 2026
Merged
Conversation
The DashPay / asset-lock / masternode / shielded rows added in #832 read their badge from the counts dictionary, but loadCounts() was never taught about their models — every new row showed 0 while its drill-in @query list rendered the real records (QA: "Contact Requests 0" outside, 4 rows inside). Count all fifteen ported models. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #832: the new explorer rows read their count badge from the
countsdictionary, butloadCounts()was never taught about the ported models — so every new row showed 0 while its drill-in@Querylist rendered the real records (QA repro: "Contact Requests 0" on the root list, 4 rows inside).Registers all fifteen ported models (DashPay family ×7, pending inputs, asset locks, masternodes, shielded ×5) in
loadCounts().Test plan
dashpaysimulator build (arm64); installed on QA-iPhone16🤖 Generated with Claude Code