fix(dashpay): write contact alias/note/hidden through setDashPayContactInfo

[QuantumExplorer]

Summary

Saving a contact's alias/note (or hiding a contact) was a complete no-op behind a "Saved" toast. QA evidence: after saving an alias, the contactAlias/contactNote mirror columns in SwiftData stayed empty.

Root cause (SDK-side): the sheet was wired to EstablishedContact.setAlias/setNote/hide, which mutate a detached FFI clone — managed_identity_get_established_contact inserts a .cloned() copy into the handle table, so the mutation never reaches the wallet manager's contact state, is never persisted, and is lost when the handle is freed. (The earlier resync-retry fix on this path cured the lookup failure but couldn't cure the phantom write.)

Fix: rewire to the SDK's real write path — ManagedPlatformWallet.setDashPayContactInfo → set_contact_info_with_external_signer, which:

1. updates the wallet manager's real contact state (local first, works offline),
2. persists it — feeding the SwiftData mirror that the contacts list, payment-row aliases, and storage explorer read,
3. publishes the self-encrypted DIP-15 contactInfo document so alias/note/hidden roam across devices (outcome: published / deferred-until-2-contacts / skipped-watch-only).

Changes:

• One combined setContactMeta(alias:note:hidden:for:) replaces the three per-field setters (the document carries all three together; the sheet sends its full current state on every save).
• Now PIN/biometric-gated — the publish signs a Platform document with the identity key, same as every other document write. A cancelled prompt is silent, not an error alert.
• The clone-mutating path (mutateEstablishedContact + resync-retry) is deleted.

Companion: platform#4140 deprecates the clone setters SDK-side so they can't be re-wired.

Test plan

• Clean dashpay simulator build (arm64); installed on QA-iPhone16
• Set an alias on a contact → PIN prompt → Saved; contactAlias mirror column non-empty (storage explorer → Contact Requests → detail) and payment rows read "Sent to "
• Relaunch → alias survives
• Hide/unhide round-trips

🤖 Generated with Claude Code

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: fcc85870-bc88-4367-b279-e8d18b89a8f8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/contact-meta-real-write

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}