feat(ui): main-identity selection and a pushed identity detail page#836
Merged
QuantumExplorer merged 1 commit intoJul 16, 2026
Merged
Conversation
Identities gains two things: - Tapping a row pushes a full detail page (WalletsScreen → accounts pattern) instead of the compact modal sheet — same cards (copyable id, info, usernames) plus the new main-identity control. - "Set as Main Identity": the SDK deliberately leaves primary-identity selection to the app layer (InMemoryWalletSummary.primaryIdentityId is always nil Rust-side), so the pick is stored app-side per wallet (UserDefaults, identity id as hex) and resolved by DWCurrentUserIdentityInfo: stored pick → identity index 0 → lowest registered index. The last fallback also fixes a latent gap — a wallet whose only identity was discovered at a higher slot used to read as unregistered. Setting main drives the registration-completion cascade so the app re-keys live: identity snapshot refresh, DWGlobalOptions username mirror re-pointed at the new main's name (or cleared — the Join banner then honestly returns), the registration-status notification chain, and the contacts snapshots. Selection is scoped to the active wallet; other wallets' identities show an explanatory line instead of the button. Rows and the page header badge the resolved main with a seal. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Caution Review failedAn error occurred during the review process. Please try again later. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two changes to the Identities screen (More → Identities):
Pushed detail page
Tapping an identity now pushes a full page (same pattern as Wallets → accounts) instead of the compact modal sheet. Same content — copyable id card, info card, owned usernames — plus the new main-identity control, with room to grow.
Set your main identity
The SDK deliberately leaves primary-identity selection to the app layer (
InMemoryWalletSummary.primaryIdentityIdis always nil Rust-side, "source the user's pick from app state"). So:UserDefaults,DWMainIdentityId.<walletIdHex>).DWCurrentUserIdentityInforesolves the current identity as stored pick → identity index 0 → lowest registered index. The new last fallback also fixes a latent gap: a wallet whose only identity was discovered at a higher slot used to read as unregistered.DWGlobalOptionsusername mirror (re-pointed at the new main's name, or cleared — the Join banner then honestly returns), the registration-status notification chain, and the contacts snapshots.Test plan
dashpaysimulator build (arm64); installed on QA-iPhone16🤖 Generated with Claude Code