fix(ui): retire Join DashPay for synced-in identities; Core Sync Status label#837
Merged
QuantumExplorer merged 1 commit intoJul 16, 2026
Conversation
…shPay retires The DWGlobalOptions.dashpayUsername mirror is written only by an on-device registration completion or the explicit Find-identities adoption. An identity that arrived any other way — synced in from Platform after a reinstall, or registered under an earlier build — left the mirror empty forever, so the More menu's Join DashPay banner (gated on the mirror since #831) kept offering "Request your username" to a wallet that already owns one. Two-part fix: - DWCurrentUserIdentityInfo.computeSnapshot backfills the mirror (username + registrationCompleted) whenever the SDK yields a real DPNS name and the mirror is empty, then posts the bridge state-change notification (async — the compute runs inside a lazy property read) so every mirror consumer re-keys. Only SDK-sourced names qualify; the pending-contested filter has already run, so a deferred contested registration cannot leak in. - CurrentUserProfileModel.updateShowJoinDashpay reads the SDK truth directly as well as the mirror, which both fixes the gate and triggers the backfill the moment the menu renders. Also renames the Sync Info menu's first row and screen header from "SwiftDashSDK SPV Status" to "Core Sync Status". Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The More menu showed Join DashPay — Request your username on a device whose wallet already owns
Quantumtester2(QA-iPhone16). #831 gated the banner on theDWGlobalOptions.dashpayUsernamemirror, but the mirror is written only by an on-device registration completion or the explicit Find-identities adoption. An identity that arrived any other way — synced in from Platform after a reinstall, or registered under an earlier build — leaves the mirror empty forever, so every mirror reader disagrees with the SDK truth rendered everywhere else.Fix
DWCurrentUserIdentityInfo.computeSnapshotnow backfillsdashpayUsername+dashpayRegistrationCompletedwhenever the SDK yields a real DPNS name and the mirror is empty, then posts the bridge state-change notification (async — the compute runs inside a lazy property read) soDWDashPayModelre-posts the canonical status update and every consumer re-keys. Only SDK-sourced names qualify (the mirror fallback can't feed itself), and the pending-contested filter has already run, so a deferred contested registration can't leak in. This fixes the whole class of stale-mirror bugs, not just this banner.CurrentUserProfileModel.updateShowJoinDashpaychecksDWCurrentUserIdentityInfo.shared.usernamealongside the mirror — which both corrects the gate immediately and triggers the backfill the moment the More menu renders.Also
Sync Info's first row (and that screen's header) renamed SwiftDashSDK SPV Status → Core Sync Status, matching the Platform / DashPay / Shielded naming of its siblings.
Test plan
IDENT-INFO :: backfilled username mirrorfires on first snapshot read)🤖 Generated with Claude Code