Skip to content

chore: fix stale dashevo badge URLs in README#516

Merged
xdustinface merged 1 commit intodashpay:v0.42-devfrom
thepastaclaw:chore/coderabbit-493-followup
Mar 12, 2026
Merged

chore: fix stale dashevo badge URLs in README#516
xdustinface merged 1 commit intodashpay:v0.42-devfrom
thepastaclaw:chore/coderabbit-493-followup

Conversation

@thepastaclaw
Copy link
Contributor

@thepastaclaw thepastaclaw commented Mar 11, 2026

Description

Follow-up from CodeRabbit review on #493.

Changes

  1. README.md — Three badge URLs still referenced dashevo instead of dashpay (license, CI status, lines-of-code)
  2. ci_config.pycrate_flags output was emitted before the crate loop, causing skipped crates (e.g., dash-fuzz on Windows) to be advertised to Codecov. Moved output to after the loop with an executed guard so coverage flags are only emitted when at least one crate actually ran.

Summary by CodeRabbit

  • Chores
    • Updated repository documentation references.

@thepastaclaw
Copy link
Contributor Author

@coderabbitai review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 11, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 663b8d44-be92-4bd0-b772-c24c6f96c5f5

📥 Commits

Reviewing files that changed from the base of the PR and between f9d92a5 and 36c627a.

📒 Files selected for processing (1)
  • README.md
✅ Files skipped from review due to trivial changes (1)
  • README.md

📝 Walkthrough

Walkthrough

Updated badge links and image URLs in README.md from the old organization (dashevo) to the new organization (dashpay) for the rust-dashcore repository. No code or functional changes were made.

Changes

Cohort / File(s) Summary
README Badge Updates
README.md
Updated LICENSE and CI Status badge links, and Lines of code badge image URL to reference the new dashpay/rust-dashcore repository path instead of dashevo/rust-dashcore.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 The warren moved, the badges flew,
From dashevo to dashpay through and through,
Just URLs shifted with a gentle hop,
A name change that surely will not stop! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'chore: fix stale dashevo badge URLs in README' accurately describes the main change: updating outdated badge URLs in the README file.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 11, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@codecov
Copy link

codecov bot commented Mar 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.88%. Comparing base (9959201) to head (36c627a).
⚠️ Report is 1 commits behind head on v0.42-dev.

Additional details and impacted files
@@              Coverage Diff              @@
##           v0.42-dev     #516      +/-   ##
=============================================
+ Coverage      66.82%   66.88%   +0.06%     
=============================================
  Files            313      313              
  Lines          64756    64756              
=============================================
+ Hits           43272    43313      +41     
+ Misses         21484    21443      -41     
Flag Coverage Δ *Carryforward flag
core 74.93% <ø> (ø)
dash-network 74.92% <ø> (ø) Carriedforward from 9959201
dash-network-ffi 34.74% <ø> (ø) Carriedforward from 9959201
dash-spv 68.28% <ø> (ø) Carriedforward from 9959201
dash-spv-ffi 34.74% <ø> (ø) Carriedforward from 9959201
dashcore 74.92% <ø> (ø) Carriedforward from 9959201
dashcore-private 74.92% <ø> (ø) Carriedforward from 9959201
dashcore-rpc 19.92% <ø> (ø) Carriedforward from 9959201
dashcore-rpc-json 19.92% <ø> (ø) Carriedforward from 9959201
dashcore_hashes 74.92% <ø> (ø) Carriedforward from 9959201
ffi 36.29% <ø> (+1.04%) ⬆️
key-wallet 65.69% <ø> (ø) Carriedforward from 9959201
key-wallet-ffi 34.74% <ø> (ø) Carriedforward from 9959201
key-wallet-manager 65.69% <ø> (ø) Carriedforward from 9959201
rpc 19.92% <ø> (ø)
spv 81.09% <ø> (-0.06%) ⬇️
wallet 65.69% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.
see 18 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.


crates = groups[args.group] or []
failed = []
executed = []
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes in .github/scripts/ci_config.py esem unrelated and should be dropped unless I'm missing something

- Fix README badge URLs: dashevo → dashpay for license, CI, and
  lines-of-code badges (codecov badges were already correct)
- Move crate_flags output after the crate loop so coverage flags are
  only emitted when at least one crate actually executed (prevents
  advertising skipped crates like dash-fuzz on Windows to Codecov)
@thepastaclaw thepastaclaw force-pushed the chore/coderabbit-493-followup branch from f9d92a5 to 36c627a Compare March 11, 2026 17:42
Copy link
Contributor Author

@thepastaclaw thepastaclaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropped the ci_config.py changes as requested — the PR now only contains the README badge URL fixes (dashevo → dashpay). Force-pushed.

@thepastaclaw thepastaclaw changed the title chore: fix stale dashevo badge URLs and ci_config crate_flags ordering chore: fix stale dashevo badge URLs in README Mar 11, 2026
@PastaPastaPasta PastaPastaPasta marked this pull request as ready for review March 11, 2026 21:07
@xdustinface xdustinface merged commit d177e98 into dashpay:v0.42-dev Mar 12, 2026
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants