chore: fix stale dashevo badge URLs in README#516
chore: fix stale dashevo badge URLs in README#516xdustinface merged 1 commit intodashpay:v0.42-devfrom
Conversation
|
@coderabbitai review |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughUpdated badge links and image URLs in README.md from the old organization (dashevo) to the new organization (dashpay) for the rust-dashcore repository. No code or functional changes were made. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Actions performedReview triggered.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v0.42-dev #516 +/- ##
=============================================
+ Coverage 66.82% 66.88% +0.06%
=============================================
Files 313 313
Lines 64756 64756
=============================================
+ Hits 43272 43313 +41
+ Misses 21484 21443 -41
*This pull request uses carry forward flags. Click here to find out more. 🚀 New features to boost your workflow:
|
.github/scripts/ci_config.py
Outdated
|
|
||
| crates = groups[args.group] or [] | ||
| failed = [] | ||
| executed = [] |
There was a problem hiding this comment.
changes in .github/scripts/ci_config.py esem unrelated and should be dropped unless I'm missing something
- Fix README badge URLs: dashevo → dashpay for license, CI, and lines-of-code badges (codecov badges were already correct) - Move crate_flags output after the crate loop so coverage flags are only emitted when at least one crate actually executed (prevents advertising skipped crates like dash-fuzz on Windows to Codecov)
f9d92a5 to
36c627a
Compare
thepastaclaw
left a comment
There was a problem hiding this comment.
Dropped the ci_config.py changes as requested — the PR now only contains the README badge URL fixes (dashevo → dashpay). Force-pushed.
Description
Follow-up from CodeRabbit review on #493.
Changes
dashevoinstead ofdashpay(license, CI status, lines-of-code)crate_flagsoutput was emitted before the crate loop, causing skipped crates (e.g.,dash-fuzzon Windows) to be advertised to Codecov. Moved output to after the loop with anexecutedguard so coverage flags are only emitted when at least one crate actually ran.Summary by CodeRabbit