chore(dashcore): drop unused modules in dashcore crate

[ZocoLini]

Summary by CodeRabbit

• Refactor
  • Removed deprecated BIP143 signing implementation.
  • Removed PSBT serialization and deserialization layer.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ddcbeb6f-9540-4bd4-b3d9-32c25a0b152b

📥 Commits

Reviewing files that changed from the base of the PR and between 63cb86d and 1ba2b36.

📒 Files selected for processing (3)

• dash/src/bip143.rs
• dash/src/lib.rs
• dash/src/serialize.rs

💤 Files with no reviewable changes (3)

• dash/src/serialize.rs
• dash/src/lib.rs
• dash/src/bip143.rs

---

📝 Walkthrough

Walkthrough

This PR removes three major components from the Dash crate: the entire BIP143 segwit signing implementation file, the PSBT serialization traits and implementations file, and a commented-out module declaration from lib.rs. These are complete file deletions totaling 709 lines removed.

Changes

Cohort / File(s)	Summary
BIP143 Signing Removal dash/src/bip143.rs	Deleted entire file containing SighashComponents and SigHashCache structs, methods for BIP143 sighash computation (sighash_all, encode_signing_data_to, signature_hash), witness access functionality, and associated test module with BIP143 test vectors.
PSBT Serialization Removal dash/src/serialize.rs	Deleted entire file containing Serialize and Deserialize trait definitions and implementations for PSBT-related types (ScriptBuf, PublicKey, ecdsa::Signature, PsbtSighashType, XOnlyPublicKey, taproot::Signature, TapTree, ControlBlock), helper functions, and test module.
Module Declaration Cleanup dash/src/lib.rs	Removed commented-out module declaration line.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 Hoppity-hop, the code takes flight,
Unused modules fade from sight,
Serialization swept away so clean,
BIP143 vanished from the scene,
A leaner crate hops bold and bright! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: removal of unused modules (bip143.rs, serialize.rs) from the dashcore crate.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

• 📝 Generate docstrings (stacked PR)
• 📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch chore/drop-unused-modules

📝 Coding Plan

• Generate coding plan for human review comments

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Tip

You can disable poems in the walkthrough.

Disable the reviews.poem setting to disable the poems in the walkthrough.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.80%. Comparing base (33cefc9) to head (1ba2b36).
⚠️ Report is 6 commits behind head on v0.42-dev.

Additional details and impacted files

@@              Coverage Diff              @@
##           v0.42-dev     #534      +/-   ##
=============================================
- Coverage      66.90%   66.80%   -0.10%     
=============================================
  Files            313      313              
  Lines          64757    64905     +148     
=============================================
+ Hits           43325    43360      +35     
- Misses         21432    21545     +113     

Flag	Coverage Δ		*Carryforward flag
core	75.02% <ø> (+0.09%)	⬆️
dash-network	74.91% <ø> (ø)		Carriedforward from 33cefc9
dash-network-ffi	34.76% <ø> (ø)		Carriedforward from 33cefc9
dash-spv	68.26% <ø> (ø)		Carriedforward from 33cefc9
dash-spv-ffi	34.76% <ø> (ø)		Carriedforward from 33cefc9
dashcore	74.91% <ø> (ø)		Carriedforward from 33cefc9
dashcore-private	74.91% <ø> (ø)		Carriedforward from 33cefc9
dashcore-rpc	19.92% <ø> (ø)		Carriedforward from 33cefc9
dashcore-rpc-json	19.92% <ø> (ø)		Carriedforward from 33cefc9
dashcore_hashes	74.91% <ø> (ø)		Carriedforward from 33cefc9
ffi	36.58% <ø> (+0.17%)	⬆️
key-wallet	65.65% <ø> (ø)		Carriedforward from 33cefc9
key-wallet-ffi	34.76% <ø> (ø)		Carriedforward from 33cefc9
key-wallet-manager	65.65% <ø> (ø)		Carriedforward from 33cefc9
rpc	19.92% <ø> (ø)
spv	80.99% <ø> (-0.12%)	⬇️
wallet	65.67% <ø> (-0.02%)	⬇️

*This pull request uses carry forward flags. Click here to find out more.
see 20 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.