Skip to content

chore(hashes): drop out-of-scope crates inside hashes crate#535

Open
ZocoLini wants to merge 1 commit intov0.42-devfrom
chore/what-is-this
Open

chore(hashes): drop out-of-scope crates inside hashes crate#535
ZocoLini wants to merge 1 commit intov0.42-devfrom
chore/what-is-this

Conversation

@ZocoLini
Copy link
Collaborator

@ZocoLini ZocoLini commented Mar 13, 2026

Do this crates have a purpose?? They are not being used, tested in CI or in the workspace

Summary by CodeRabbit

  • Tests

    • Removed comprehensive fuzzing targets and infrastructure for testing hash implementations.
    • Removed JSON and CBOR serialization schema validation tests.
  • Chores

    • Removed embedded microcontroller crate and examples.
    • Removed fuzzing orchestration and continuous integration scripts.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 13, 2026

📝 Walkthrough

Walkthrough

Complete removal of embedded ARM example, schema validation test suite, and Honggfuzz fuzzing framework from the hashes crate. This eliminates approximately 714 lines across 14 files including Cortex-M binaries, test harnesses, fuzz targets, and build orchestration scripts.

Changes

Cohort / File(s) Summary
Embedded ARM Example
hashes/embedded/Cargo.toml, hashes/embedded/memory.x, hashes/embedded/src/main.rs
Removed Cortex-M no_std embedded binary example with heap allocator configuration, linker memory layout, and hash computation tests.
Schema Validation Tests
hashes/extended_tests/schemars/Cargo.toml, hashes/extended_tests/schemars/src/main.rs
Removed Schemars-based JSON schema validation test suite covering multiple hash types (SHA-256, HMAC-SHA512, RIPEMD160, SHA1, SHA512, SipHash24, etc.).
Fuzzing Infrastructure
hashes/fuzz/Cargo.toml, hashes/fuzz/fuzz_targets/sha1.rs, hashes/fuzz/fuzz_targets/sha256.rs, hashes/fuzz/fuzz_targets/sha512.rs, hashes/fuzz/fuzz_targets/sha512_256.rs, hashes/fuzz/fuzz_targets/ripemd160.rs, hashes/fuzz/fuzz_targets/cbor.rs, hashes/fuzz/fuzz_targets/json.rs, hashes/fuzz/travis-fuzz.sh
Removed entire Honggfuzz-based fuzzing framework including manifest, seven hash algorithm fuzz targets with round-trip serialization/deserialization tests, and Travis CI fuzzing orchestration script.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 Farewell to fuzz and tests so grand,
Embedded code leaves the land,
Schemas fade and harnesses part,
Streamlined crate, a cleaner heart!
No more fuzzing, the path is clear—
A lighter repo, we celebrate here!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title accurately describes the main change: removing out-of-scope crates (embedded, extended_tests/schemars, and fuzz directories) from the hashes crate.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/what-is-this
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Mar 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.07%. Comparing base (b946271) to head (f862277).

Additional details and impacted files
@@              Coverage Diff              @@
##           v0.42-dev     #535      +/-   ##
=============================================
+ Coverage      66.89%   67.07%   +0.17%     
=============================================
  Files            313      313              
  Lines          64753    64753              
=============================================
+ Hits           43317    43432     +115     
+ Misses         21436    21321     -115     
Flag Coverage Δ *Carryforward flag
core 75.02% <ø> (ø)
dash-network 75.00% <ø> (ø) Carriedforward from b946271
dash-network-ffi 34.76% <ø> (ø) Carriedforward from b946271
dash-spv 68.26% <ø> (ø) Carriedforward from b946271
dash-spv-ffi 34.76% <ø> (ø) Carriedforward from b946271
dashcore 75.00% <ø> (ø) Carriedforward from b946271
dashcore-private 75.00% <ø> (ø) Carriedforward from b946271
dashcore-rpc 19.92% <ø> (ø) Carriedforward from b946271
dashcore-rpc-json 19.92% <ø> (ø) Carriedforward from b946271
dashcore_hashes 75.00% <ø> (ø) Carriedforward from b946271
ffi 37.76% <ø> (+1.16%) ⬆️
key-wallet 65.64% <ø> (ø) Carriedforward from b946271
key-wallet-ffi 34.76% <ø> (ø) Carriedforward from b946271
key-wallet-manager 65.64% <ø> (ø) Carriedforward from b946271
rpc 19.92% <ø> (ø)
spv 81.06% <ø> (-0.03%) ⬇️
wallet 65.67% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.
see 19 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ZocoLini ZocoLini changed the title chore(idk): drop out-of-scope crates inside hashes crate chore(hashes): drop out-of-scope crates inside hashes crate Mar 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant