test: add 200 block regtest blockchain support#537
Draft
xdustinface wants to merge 1 commit intov0.42-devfrom
Draft
test: add 200 block regtest blockchain support#537xdustinface wants to merge 1 commit intov0.42-devfrom
xdustinface wants to merge 1 commit intov0.42-devfrom
Conversation
This improves the full rust dashd integration tests runtime on my MBP M2pro (including the coming mempool tests) from ~65s to ~35s. The 40k chain is still included for better coverage in wallet integration tests where it matter but this PR also adjusts few other tests where the 40k chain is not needed. Overview: - Rename `DASHD_DATADIR` to `DASHD_TEST_DATA` (root containing all variants) - Parameterize `setup-dashd.py` to download both `regtest-40000` and `regtest-200` variants into the shared root - Add `DashCoreConfig::from_env_variant()` to select a data variant - Extract shared init logic into `DashdTestContext::create()` - Add new `TestChain` enum, integrate it into `DashdTestContext::new` - Update `TEST_DATA_VERSION` to `v0.0.3`
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v0.42-dev #537 +/- ##
=============================================
- Coverage 66.89% 66.85% -0.05%
=============================================
Files 313 313
Lines 64753 64753
=============================================
- Hits 43317 43289 -28
- Misses 21436 21464 +28
*This pull request uses carry forward flags. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This improves the full rust dashd integration tests runtime on my MBP M2pro (including the coming mempool tests) from ~65s to ~35s.
The 40k chain is still included for better coverage in wallet integration tests where it matter but this PR also adjusts few other tests where the 40k chain is not needed.
Overview:
DASHD_DATADIRtoDASHD_TEST_DATA(root containing all variants)setup-dashd.pyto download bothregtest-40000andregtest-200variants into the shared rootDashCoreConfig::from_env_variant()to select a data variantDashdTestContext::create()TestChainenum, integrate it intoDashdTestContext::newTEST_DATA_VERSIONtov0.0.3