ci: re-disable carryforward flags

[xdustinface]

Didn't work. Maybe it need few runs inbetween to get rid of all stale carryforward data so lets try again.

Summary by CodeRabbit

• Configuration Changes
  • Modified default flag carryforward setting - flags will no longer persist across builds by default.

[coderabbitai]

📝 Walkthrough

Walkthrough

The default carryforward behavior for code coverage flags in .codecov.yml is toggled from true to false. This configuration change modifies how flag statuses are persisted across consecutive builds by default in the Codecov coverage tracking system.

Changes

Cohort / File(s)	Summary
Codecov Configuration .codecov.yml	Changed flag_management.default_rules.carryforward from true to false, altering the default flag carryforward behavior across builds.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

• ci: disable carryforward flags to flush stale data #543 — Makes the identical code-level change, flipping the same carryforward setting to false.
• ci: re-enable carryforward flags (#543) #544 — Modifies the same setting but in the opposite direction (changes from false back to true), directly reversing this configuration.

Poem

🚩 A flag's journey now takes a different path,
No carryforward by default—a cleaner math.
One line, one boolean, a choice so clear,
Coverage flags reset with each new year! 🐰

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 're-disable carryforward flags' accurately describes the main change: reverting the carryforward behavior back to disabled in the .codecov.yml configuration file.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch ci/disable-carryforward

📝 Coding Plan

• Generate coding plan for human review comments

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.codecov.yml:
- Line 24: The Codecov config currently sets carryforward: false which causes
missing per-group uploads (core, spv, wallet, ffi, rpc) to be treated as absent
and can make PR status unstable; update the .codecov.yml to either enable
carryforward (set carryforward: true) or explicitly set
flag_coverage_not_uploaded_behavior to a safe option (e.g., "skip" or "ignore")
so that missing group uploads don't produce incomplete flag data and flaky
status checks—make this change near the existing carryforward entry and ensure
groups referenced (core/spv/wallet/ffi/rpc) are taken into account.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: fd65a2ba-91bf-43ec-aa6a-00135f6ba0ff

📥 Commits

Reviewing files that changed from the base of the PR and between 4b02de1 and 3cecf90.

📒 Files selected for processing (1)

• .codecov.yml

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.94%. Comparing base (4b02de1) to head (3cecf90).
⚠️ Report is 1 commits behind head on v0.42-dev.

Additional details and impacted files

@@              Coverage Diff              @@
##           v0.42-dev     #545      +/-   ##
=============================================
- Coverage      65.95%   65.94%   -0.02%     
=============================================
  Files            311      311              
  Lines          64586    64586              
=============================================
- Hits           42599    42589      -10     
- Misses         21987    21997      +10     

Flag	Coverage Δ
core	75.02% <ø> (ø)
ffi	37.14% <ø> (ø)
rpc	19.92% <ø> (ø)
spv	80.93% <ø> (-0.09%)	⬇️
wallet	65.67% <ø> (ø)
see 1 file with indirect coverage changes