Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #6
Issues include
Alt Text
Alt text is kind of a mess with quarto; highly configurable but reasonable defaults aren't applied. Documentation of the various options here. Because a figure's caption is considered separately from alt text, I've decided to leave the captions as they were originally written and insert empty alt text as suggested by Web AIM after I made the alt text the same as the figure caption: "Change either the alternative text or the adjacent text to eliminate the redundancy. In most cases, you can give the image empty/null alternative text (alt="") because the content of the image is already provided in context through text."
Color Contrast
Color contrast violations appear when code cells intentionally output errors for instructional purposes. I added custom CSS to use high contrast colors. I also removed a code element from a link; "Why? Find out the answer in the official Python documentation on
pop!" became: "Why? Find out the answer in the official Python documentation onpop!"Aria Allowed Attributes
This violation has to do with
callout-note's like at the bottom of16-measurements/iteration-ii.html. I added a script that will injectrole="button"to fix this.Scrollable Region Focusable
This violation appears for scrollable regions like wide blocks of code. I added a script that injects
tabindex=0so they are able to be accessed by keyboard users.