Open
Conversation
mdhaber
commented
Feb 19, 2026
mdhaber
force-pushed
the
apply_where_kwargs
branch
from
97cceae to
1acee7a
Compare
Contributor
Author
|
I took a second look through this, and I don't see anything I want to change. Turned out quite clean, and it will make some dependent code much nicer. |
lucascolley
approved these changes
Feb 20, 2026
Member
lucascolley
left a comment
lucascolley
left a comment
There was a problem hiding this comment.
all seems fine to me. Want to take a look @crusaderky ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes gh-612