fix: replace ForAllValues:StringLike with StringLike for ram:ResourceShareName conditions#1879
Open
arjunp99 wants to merge 2 commits intodata-dot-all:mainfrom
Open
fix: replace ForAllValues:StringLike with StringLike for ram:ResourceShareName conditions#1879arjunp99 wants to merge 2 commits intodata-dot-all:mainfrom
arjunp99 wants to merge 2 commits intodata-dot-all:mainfrom
Conversation
…ShareName conditions - Remove ForAllValues qualifier for single-value keys in RAM policy statements - Affects RamTag, RamUpdateResource, RamAssociateResource, and RamInvitations statements
… RAM keys Addresses security recommendation by using appropriate condition operators for ram:ResourceShareName in pivot role data sharing policy.
petrkalos
approved these changes
Dec 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
ForAllValues:StringLikewithStringLikefor single-value RAM keysThe
ForAllValuesqualifier is unnecessary for keys likeram:ResourceShareNamethat can only have one value per request.This change removes ambiguity and aligns with AWS IAM best practices for condition operators.
File:
backend/dataall/modules/s3_datasets_shares/cdk/pivot_role_data_sharing_policy.pyChanges:
RamTag statement (line 64)
RamUpdateResource statement (line 83)
RamAssociateResource statement (line 91)
RamInvitations statement (line 108)