GH-1900 Enhance shared datasets view with principal details and improved navigation#1902
Open
surya-madhav wants to merge 1 commit intodata-dot-all:mainfrom
Open
GH-1900 Enhance shared datasets view with principal details and improved navigation#1902surya-madhav wants to merge 1 commit intodata-dot-all:mainfrom
surya-madhav wants to merge 1 commit intodata-dot-all:mainfrom
Conversation
…ls and improved navigation Adds principalName and principalType fields to the shared datasets display, improving clarity on whether data is shared with a team or consumption role. Updates the UI with icons, tooltips showing full IAM role ARNs, and dedicated navigation buttons for viewing shares and datasets.
Collaborator
TejasRGitHub
left a comment
TejasRGitHub
left a comment
There was a problem hiding this comment.
Hey @surya-madhav , can you also include the fix that you did for the qs frontend package. I can see that the npm audit is failing. Let me know if it can be easily added here or not
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Detail
This PR addresses UX issues in the "Data Shared With You" section by improving navigation and data visibility:
Navigation Enhancements:
/console/shares/${shareUri}, reducing navigation clicks from 3-4 to 1Display Improvements:
principalNameandprincipalTypefields in the API (fields already exist in database)Technical Changes:
principalNameandprincipalTypefields in GraphQL API (already in database, just not returned)Relates
Security
Does this PR introduce or modify any input fields or queries - this includes
fetching data from storage outside the application (e.g. a database, an S3 bucket)?
principalName) to the SELECT clause of an existing parameterized queryDoes this PR introduce any functionality or component that requires authorization?
Are you using or adding any cryptographic features?
Are you introducing any new policies/roles/users?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.