Add pz and pdz#11
Open
matthewturk wants to merge 4 commits into
Open
Conversation
Member
Author
|
This should be ready for review. I think the tests check that it's behaving correctly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This starts the process of adding pz and pdz to the toolset, so that we can supply more than just the exact values sliced. They're at the end of the argument list so in principle this shouldn't have any API changes on the TS/JS side. On the other hand it's also possible that
Option<>won't quite work like that for us.There is probably a better way to do it than I've done it here, with the default of 0's and 1's being initialized into the array.