resolve devnet addresses from FWSS at runtime, strip from generator#10
Merged
resolve devnet addresses from FWSS at runtime, strip from generator#10
Conversation
parkan
force-pushed
the
fix/devnet-address-resolution
branch
from
a3af1f4 to
538f903
Compare
Collaborator
Author
|
the alternative here would be to force create the contract at whatever address instead of forking, but given that we aren't doing any SC dev here that feels worse |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the root of trust contracts aren't CREATE2 so we can't predict the devnet deployment address; this separates the devnet logic out and makes the verify-address workflow pass