lift signer to top level since not PDP specific#4
Merged
Conversation
parkan
force-pushed
the
refactor/signer-package
branch
from
953fa8d to
39f4582
Compare
Move Signer interface out of pdp/ into signer/ package. A secp256k1 key can sign both native Filecoin messages (blake2b) and Ethereum transactions (keccak256) from the same key material. Interfaces: signer.Signer - Filecoin signing (all key types) signer.EVMSigner - adds EVM transaction signing (secp256k1 only) Implementations: Secp256k1Signer - dual-protocol, implements EVMSigner BLSSigner - Filecoin-only, implements Signer Accepts lotus wallet export format directly via FromLotusExport(). pdp.Signer and pdp.NewPrivateKeySigner kept as aliases for backward compatibility. Also bumps blst to v0.3.16 for C23 compat.
parkan
force-pushed
the
refactor/signer-package
branch
from
39f4582 to
b27d67a
Compare
Collaborator
Author
|
added |
Collaborator
Author
|
@anjor I'm going to merge this to keep moving on the singularity integration that assumes this interface, if you have concerns please raise them in separate PR/issue, depending on severity |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
signer/package with dual-protocol Filecoin/EVM signing interfacesSecp256k1Signersigns both native Filecoin messages and Ethereum transactions from the same keyBLSSignerfor Filecoin-only signingFromLotusExport()pdp.Signerkept as type alias for backward compat