Skip to content

GetRail handle tuple output#9

Merged
parkan merged 2 commits intodata-preservation-programs:masterfrom
JAG-UK:master
Mar 25, 2026
Merged

GetRail handle tuple output#9
parkan merged 2 commits intodata-preservation-programs:masterfrom
JAG-UK:master

Conversation

@JAG-UK
Copy link
Copy Markdown
Contributor

@JAG-UK JAG-UK commented Mar 24, 2026

The ABI for GetRail returns a tuple, not a struct, so unpack tuple before interpreting it

@JAG-UK
Copy link
Copy Markdown
Contributor Author

JAG-UK commented Mar 24, 2026

This addresses issue #8 and it Works On My Computer with real rails on Calib (specifically 14108 on https://pay.filecoin.cloud/calibration/rails).

Looking at the ABI I think this was simply a bug and we don't need to handle the originally-implied unpack-straight-to-struct case but if I'm wrong let me know and I'll add the additional safety/testing.

@JAG-UK
Copy link
Copy Markdown
Contributor Author

JAG-UK commented Mar 24, 2026

Also I notice that devnet has been deleted from the generated constants here. That's not a deliberate act of sabotage on my part: I just ran the command the CI told me to and this is what it did (probably because I don't have a devnet on this machine). Hope that's OK, again LMK what I can do to fix it if needed.

@parkan
Copy link
Copy Markdown
Collaborator

parkan commented Mar 25, 2026

@JAG-UK thanks for the patch, in fact your approach of not checking in the devnet is probably more correct than what we were doing previously, which was sloppily checking in a non-CREATE2'd address which is useless to have in repo and breaks the verify-address test

@parkan parkan merged commit e32fd52 into data-preservation-programs:master Mar 25, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants