store keystore-relative names in wallets.key_path#661
Merged
Conversation
KeyStore.Put previously returned an absolute filesystem path which got written verbatim into wallets.key_path. Get/Has/Delete then did raw os.ReadFile/os.Stat on that stored path, ignoring ks.dir entirely. This made the DB non-portable -- a wallet imported on one host could not be loaded on another host with a different keystore root, even when the key file itself had been copied over. Put now returns just the basename (the address), and Get/Has/Delete resolve it against ks.dir. A validateName guard rejects separators and . / .. so a DB with legacy absolute paths surfaces as a clear error rather than a silent path-escape. KeyInfo.Path renamed to .Name. Callers updated; no compat shim -- any deployment that already ran export-keys needs a one-shot UPDATE wallets SET key_path = address.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KeyStore.Putreturned an absolute path that got written intowallets.key_path.Get/Has/Deletethen did rawos.ReadFileon the stored path, ignoringks.dir. DB was non-portable across hosts with different keystore roots.Putnow returns the basename;Get/Has/Deleteresolve againstks.dirvalidateNamerejects separators/./..so legacy absolute paths error out loudlyKeyInfo.Path->KeyInfo.NameNo compat shim. Existing deployments need
UPDATE wallets SET key_path = address;.