Merged
Conversation
Car.AttachmentID is ON DELETE SET NULL (for fast prep deletion with async cleanup). When a prep is deleted and re-created, the old car rows survive with attachment_id = NULL while a new row gets created for the same piece_cid. GetMetadataHandler used .First() which picks the oldest row by PK -- an orphan -- and returned 404 even though a valid row existed. findPiece already iterates past orphans; this aligns the metadata lookup with that behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GetMetadataHandlerused.First(&car)which picks the oldest car row by PK. When multiple rows exist for the samepiece_cid, older rows can haveattachment_id = NULL(fromON DELETE SET NULLafter a prior prep was deleted). The handler would return 404 "piece metadata not found" even though a valid, linked car row existed./piece/:id(findPiece) iterates all cars and skips those with nilAttachmentID, so the piece itself served correctly while metadata 404'd for the same CID.attachment_id IS NOT NULL.Test plan
go vet+staticcheckclean