Skip to content

Use idiomatic httptest handler failures in labs installer tests #5623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
janniklasrose merged 1 commit into from
Jun 17, 2026
Merged

Use idiomatic httptest handler failures in labs installer tests #5623

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 9 additions & 10 deletions cmd/labs/project/installer_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,8 +193,8 @@ func TestInstallerWorksForReleases(t *testing.T) {
})
return
}
t.Logf("Requested: %s", r.URL.Path)
t.FailNow()
t.Errorf("unexpected request: %s", r.URL.Path)
http.Error(w, "unexpected request", http.StatusInternalServerError)
}))
defer server.Close()

Expand Down Expand Up @@ -262,8 +262,8 @@ func TestOfflineInstallerWorksForReleases(t *testing.T) {
})
return
}
t.Logf("Requested: %s", r.URL.Path)
t.FailNow()
t.Errorf("unexpected request: %s", r.URL.Path)
http.Error(w, "unexpected request", http.StatusInternalServerError)
}))
defer server.Close()

Expand Down Expand Up @@ -362,8 +362,8 @@ func TestInstallerWorksForDevelopment(t *testing.T) {
})
return
}
t.Logf("Requested: %s", r.URL.Path)
t.FailNow()
t.Errorf("unexpected request: %s", r.URL.Path)
http.Error(w, "unexpected request", http.StatusInternalServerError)
}))
defer server.Close()

Expand Down Expand Up @@ -453,8 +453,8 @@ func TestUpgraderWorksForReleases(t *testing.T) {
})
return
}
t.Logf("Requested: %s", r.URL.Path)
t.FailNow()
t.Errorf("unexpected request: %s", r.URL.Path)
http.Error(w, "unexpected request", http.StatusInternalServerError)
}))
defer server.Close()

Expand Down Expand Up @@ -496,7 +496,6 @@ func TestUpgraderWorksForReleases(t *testing.T) {
}
}
if !pi {
t.Logf(`Expected stub command 'python[\S]+ -m pip install --upgrade --upgrade-strategy eager .' not found`)
t.FailNow()
t.Fatal(`Expected stub command 'python[\S]+ -m pip install --upgrade --upgrade-strategy eager .' not found`)
}
}
Loading