direct: strip /Workspace prefix from parent_path in dashboard PATCH#5659
Closed
denik wants to merge 1 commit into
Closed
direct: strip /Workspace prefix from parent_path in dashboard PATCH#5659denik wants to merge 1 commit into
denik wants to merge 1 commit into
Conversation
The Lakeview PATCH API rejects parent_path values that begin with /Workspace/ (unlike the POST API which silently strips that prefix). The direct engine was sending the prefix, causing dashboard renames to fail on cloud with a 404. Also teach the testserver to reject /Workspace/ in PATCH parent_path, so the change-name test reproduces the cloud failure locally. Co-authored-by: Denis Bilenko <denis.bilenko@databricks.com>
Contributor
Approval status: pending
|
Collaborator
Integration test reportCommit: 753ac87
22 interesting tests: 13 SKIP, 7 KNOWN, 2 flaky
Top 20 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parent_pathwith a/Workspace/prefix (unlike the POST API which silently strips it)DoUpdatebefore sending the PATCH request/Workspace/in PATCHparent_pathso thechange-nametest reproduces the failure locallyTest plan
go test ./acceptance -run TestAccept/bundle/resources/dashboardspasses locallytestme-awscloud run passes forbundle/resources/dashboards/change-nameThis pull request and its description were written by Isaac.