Stop keeping the docs schema on main; publish it only to docgen#5663
Draft
shreyas-goenka wants to merge 1 commit into
Draft
Stop keeping the docs schema on main; publish it only to docgen#5663shreyas-goenka wants to merge 1 commit into
shreyas-goenka wants to merge 1 commit into
Conversation
shreyas-goenka
force-pushed
the
shreyas-goenka/remove-docs-schema-from-main
branch
2 times, most recently
from
902aee9 to
6f59c51
Compare
bundle/schema/jsonschema_for_docs.json was a checked-in generated artifact on main, but nothing in the CLI reads it — the binary embeds jsonschema.json, and bundle/docsgen regenerates from Go types. Its only consumer is downstream docs tooling, which now reads the schema from the docgen branch. - Delete bundle/schema/jsonschema_for_docs.json and remove generate-schema-docs from the `all`/`generate` aggregators and the Taskfile, so `task generate` no longer recreates it on main. (generate-check, the CI drift subset, already excluded it.) - The update-schema-docs workflow now regenerates the schema straight into the docgen worktree and commits it there, instead of generating on main and copying. Drops the now-unneeded "assert only the docs schema changed on main" and capture steps. - Drop the file from .wsignore, .gitattributes, and the auto-generated-files rule. Co-authored-by: Isaac
shreyas-goenka
force-pushed
the
shreyas-goenka/remove-docs-schema-from-main
branch
from
6f59c51 to
a4951a2
Compare
Contributor
|
An authorized user can trigger integration tests manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the checked-in docs schema from
mainand publishes it only to thedocgenbranch.